chore(deps): upgrade to turbo v2, pnpm v9 & improve dev scripts #1720
Conversation
It's not very useful when it all comes down to it
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
.github/workflows/browserslist.yml
Outdated
There was a problem hiding this comment.
This action doesn't really work well with pnpm
| @@ -23,12 +22,11 @@ jobs: | |||
| TURBO_TEAM: ${{ vars.TURBO_TEAM }} | |||
| steps: | |||
| - uses: actions/checkout@v4 | |||
| - uses: pnpm/action-setup@v2 | |||
| - uses: pnpm/action-setup@v4 | |||
There was a problem hiding this comment.
v4 automatically supports packageManager in package.json, so the corepack command is no longer necessary
| @@ -23,7 +22,7 @@ jobs: | |||
| with: | |||
| app-id: ${{ secrets.ECOSPARK_APP_ID }} | |||
| private-key: ${{ secrets.ECOSPARK_APP_PRIVATE_KEY }} | |||
| - uses: connor-baer/action-sync-branch@main | |||
| - uses: connor-baer/action-sync-branch@v1.1.0 | |||
There was a problem hiding this comment.
Don't know why renovate missed pinning this one, it's pinned now though
There was a problem hiding this comment.
This workaround is no longer needed, as Google fixed this back in May googleapis/release-please#2281 🥳
| const sanityExports = {} | ||
| for (const key of Object.keys(sanityPkg.exports)) { | ||
| if (key === '.') continue | ||
| const subexport = path.join('sanity', key) | ||
| sanityExports[subexport] = requireResolve(subexport) | ||
| } | ||
| sanityExports['sanity'] = requireResolve('sanity') | ||
|
|
There was a problem hiding this comment.
We'll ship a first class utility for this in next-sanity later. This feature is based on the new aliasing that sanity dev does since v3.53.0
There was a problem hiding this comment.
Cool! Also TIL about Import Assertions
| @@ -5,9 +5,9 @@ | |||
|
|
|||
| import {visionTool} from '@sanity/vision' | |||
| import {defineConfig} from 'sanity' | |||
| import {presentationTool} from 'sanity/presentation' | |||
There was a problem hiding this comment.
Thanks to the link-workspace-packages = deep in the root .npmrc we can use e2e tests that import from sanity/presentation and still have it use the workspace version instead of npm 🥳
stipsan
force-pushed
the
turbo-v2-pnpm-v9
branch
from
a72c5b9
to
50f8a00
Compare
To improve dev scripts the new
turbo watchcommand is used, it re-runs thedevcommands inpackages/*that currently runspkg build --strict.Once
@sanity/pkg-utilshandles TS types with itswatchcommand we can move to a simplified setup withturbo run devagain instead ofturbo watch dev, that handles runningbuildcommands during warm up. The reason we manually runbuildbeforeturbo watchis due toturborunningwatchtasks all in parallel, which means you easily havesanity devhappening before packages it uses, like@sanity/presentation, is built.While at it I've bumped
@sanity/ui,sanitypackages, and enabled testing our@sanity/styled-componentstemporary fork (related studio PR).