fix(spring): fix write pom placeholders. #1099
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
1 task
|
@zhumin8 Ah, I was also running into the issue that parent version needs to specified in the generated pom. Since we are aligning versions with Together with spring-cloud-gcp side edits, this would look like GoogleCloudPlatform/spring-cloud-gcp@79e0864 as a POC. |
|
@emmileaf Yeah, |
zhumin8
force-pushed
the
fix-write-pom
branch
from
02bc441 to
bd9afaf
Compare
|
reverting the |
|
Kudos, SonarCloud Quality Gate passed! |
diegomarquezp
approved these changes
Nov 23, 2022
emmileaf
approved these changes
Nov 23, 2022
zhumin8
added a commit
to GoogleCloudPlatform/spring-cloud-gcp
that referenced
this pull request
Nov 23, 2022
- Remove version replacement for generated modules, these versions should be inferred from parent pom. - set parent version to project version. - [x] Also need to adjust relevant placeholder from gapic-generator-java side. googleapis/sdk-platform-java#1099 Using placeholder for parent version for unblocking generation workflow setup. For future improvements: - Use `revision` to get versions from spring-cloud-gcp parent pom. This will involve changes for all modules with `spring-cloud-gcp` as parent.
zhumin8
added a commit
that referenced
this pull request
Dec 1, 2022
) This is the last item missed in #1099.
zhumin8
added
the
spring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{starter-version}}are not needed anymore as we inherit version from parent pom.spring-cloud-gcp-coreandspring-boot-starter, specified ingenereated-parentpom