-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: removing root src not used by Maven #1156
Conversation
"ci / build (11)" failed:
|
9997873
to
035d667
Compare
035d667
to
e767a98
Compare
81 tests pass and 35 fail locally
Around 31 tests rely on path written in test code. Fixing them to have 'gapic-generator-java' would pass the tests.
The failing test passed.
However, such changes would make Maven test fail. I need to learn constraints further.
|
"ci / build (8)" and "ci / build (11)" succeeded after removing Bazel's unit tests, which Blake plans to remove in https://github.com/googleapis/gapic-generator-java/pull/918/files anyway. Now coverage job, which relies on the unit tests, is remaining. As per Blake, there's a plan to move it to Maven-based. |
Bazel unit tests are being removed as part of Bazel to Maven migration.
Retrying ci/build (8).
|
783b403 was passing for ci / build (8) but now it's failing. It succeeds in my local:
|
I am seeing the same error in a different PR so the root cause is likely not from any commits here, but perhaps a github actions env or workflow change? |
Thank you! |
Kudos, SonarCloud Quality Gate passed! |
The correct source of "src" of gapic-generator-java is now gapic-generator-java/src, not the one at the root.