build: use bazelisk avoid unexpected Bazel version upgrades #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Bazel version 6.0.0 is suspicious.
Indeed, I'm able to reproduce the issue in Bazel 6.0.0. https://github.com/bazelbuild/bazel/releases 6.0.0 was released today. |
suztomo
changed the title
suztomo
changed the title
blakeli0
reviewed
Dec 19, 2022
.github/workflows/ci.yaml
Outdated
| @@ -75,20 +52,63 @@ jobs: | |||
| retention-days: 5 | |||
|
|
|||
| - name: Java Linter | |||
| run: bazel --batch run //:google_java_format_verification | |||
| run: bazelisk --batch run //:google_java_format_verification | |||
There was a problem hiding this comment.
I think we can remove Java linter as well if it's already included in the Maven build.
blakeli0
approved these changes
Dec 19, 2022
suztomo
added
the
automerge
|
Kudos, SonarCloud Quality Gate passed!
|
gcf-merge-on-green
bot
removed
the
automerge
emmileaf
pushed a commit
that referenced
this pull request
Dec 20, 2022
" ci / build (8) " has been failing in https://togithub.com/googleapis/gapic-generator-java/pull/1156. Creating an empty pull request to see the build failures. This PR changes: - The unit tests in Bazel and "coverage" on it have been removed. @blakeli0 intends to remove it in another PR anyway. - GitHub Actions to use bazelisk command that keeps the Bazel version stable. - The client library generation job is separated from the build job. As per https://togithub.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md, ubuntu-latest has bazelisk installed.
emmileaf
added a commit
that referenced
this pull request
Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
" ci / build (8) " has been failing in #1156. Creating an empty pull request to see the build failures.
This PR changes:
As per https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md, ubuntu-latest has bazelisk installed.