Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(spring): update spring branch with Bazel CI fix from main #1164

Merged
merged 1 commit into from
Dec 20, 2022
Merged

build(spring): update spring branch with Bazel CI fix from main #1164

merged 1 commit into from
Dec 20, 2022

Conversation

emmileaf
Copy link
Contributor

@emmileaf emmileaf commented Dec 20, 2022 •
edited
Loading

@suztomo @emmileaf
build: use bazelisk avoid unexpected Bazel version upgrades (#1163)
849f04d 
" ci / build (8) " has been failing in https://togithub.com/googleapis/gapic-generator-java/pull/1156. Creating an empty pull request to see the build failures.

This PR changes:

- The unit tests in Bazel and "coverage" on it have been removed. @blakeli0 intends to remove it in another PR anyway.
- GitHub Actions to use bazelisk command that keeps the Bazel version stable.
- The client library generation job is separated from the build job.

As per https://togithub.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md, ubuntu-latest has bazelisk installed.
@emmileaf emmileaf added the spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch. label Dec 20, 2022
@sonarcloud
Copy link

sonarcloud bot commented Dec 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@emmileaf emmileaf marked this pull request as ready for review December 20, 2022 16:07
@emmileaf emmileaf requested review from a team as code owners December 20, 2022 16:07
@emmileaf emmileaf merged commit 63291e0 into autoconfig-gen-draft2 Dec 20, 2022
@emmileaf emmileaf deleted the autoconfig-gen-draft2-cherrypick branch December 20, 2022 17:03
@zhumin8 zhumin8 mentioned this pull request Dec 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin approved these changes

@suztomo suztomo Awaiting requested review from suztomo

@zhumin8 zhumin8 Awaiting requested review from zhumin8

@blakeli0 blakeli0 Awaiting requested review from blakeli0

@diegomarquezp diegomarquezp Awaiting requested review from diegomarquezp

Assignees
No one assigned
Labels
spring pr that's related to spring code gen, intend to merge into autoconfig-gen-draft2 branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmileaf @meltsufin @suztomo