Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci(showcase): add showcase testing #1188

Merged
merged 20 commits into from
Dec 21, 2022
Merged

ci(showcase): add showcase testing #1188

merged 20 commits into from
Dec 21, 2022

Conversation

burkedavison
Copy link
Member

Due to the heavy repo refactoring, it was cleaner to apply the previous PR changes to a new branch.

@burkedavison burkedavison requested a review from a team as a code owner December 21, 2022 16:33
@snippet-bot
Copy link

snippet-bot bot commented Dec 21, 2022 •
edited
Loading

Here is the summary of changes.

You are about to add 169 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

blakeli0
blakeli0 reviewed Dec 21, 2022
View reviewed changes
showcase/pom.xml Outdated Show resolved Hide resolved
blakeli0
blakeli0 reviewed Dec 21, 2022
View reviewed changes
showcase/pom.xml
Java idiomatic client for Google Cloud Platform services.
</description>

<parent>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that we have a proper multi module set up, you may want to consider using the parent bom like other modules did, so that we don't have to list all the versions. It could be improved in a separate PR though, @suztomo may also have some ideas.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gapic-generator-java-bom is the closest to what the client libraries will use to declare versions. Import it in the dependencyManagement section.

suztomo
suztomo reviewed Dec 21, 2022
View reviewed changes
.github/workflows/ci-maven.yaml
curl --location https://github.com/googleapis/gapic-showcase/releases/download/v${SHOWCASE_VERSION}/gapic-showcase-${SHOWCASE_VERSION}-linux-amd64.tar.gz --output /usr/src/showcase/showcase-${SHOWCASE_VERSION}-linux-amd64.tar.gz
cd /usr/src/showcase/
tar -xf showcase-*
./gapic-showcase run &
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this run Bazel somewhere? If not, then Bazel cache above are not needed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bazel is invoked when generating the showcase client for golden testing.
https://github.com/googleapis/gapic-generator-java/pull/1188/files#diff-2786ec798ce7e963cf28c2b9ac79e3e7c7d0ac47114bfec84de71d09cfe93a20R45-R48

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use bazelisk. You can save your time troubleshooting unexpected Bazel version upgrade in future.

#1163

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

showcase/pom.xml
Java idiomatic client for Google Cloud Platform services.
</description>

<parent>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gapic-generator-java-bom is the closest to what the client libraries will use to declare versions. Import it in the dependencyManagement section.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@burkedavison burkedavison merged commit 820f457 into main Dec 21, 2022
@burkedavison burkedavison deleted the showcase branch December 21, 2022 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suztomo suztomo suztomo approved these changes

@blakeli0 blakeli0 Awaiting requested review from blakeli0

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burkedavison @suztomo @blakeli0