Skip to content
This repository has been archived by the owner on Sep 7, 2022. It is now read-only.

adds Mojo support #70

Closed
wants to merge 28 commits into from
Closed

adds Mojo support #70

wants to merge 28 commits into from

Conversation

collinjackson
Copy link

fixes #71

@collinjackson collinjackson mentioned this pull request Jan 13, 2016
Closed
@davenotik
Copy link
Contributor

@sethladd so what exactly did you want us to test here? Shall a corresponding issue be opened?

@sethladd
Copy link
Contributor

Hi @davenotik just let us know if we break the js-interop version of this library :)

@collinjackson
Copy link
Author

This PR shouldn't be merged until dart-lang/sdk#24581 is fixed. I filed #71 to track the issue. For now, Flutter developers should use the https://github.com/flutter/firebase-dart fork.

@collinjackson
Copy link
Author

I identified an issue with this PR -- the Dart VM doesn't notify us when Firebase objects are garbage collected, so we can't close the Mojo handles and just leak them. We need to multiplex all the Firebase API calls through a single proxy, and add an API to Firebase that allows the developer to manually close the proxy if they want to release all resources associated with the Firebase. (This won't do anything in the JS implementation.)

collinjackson and others added 22 commits March 4, 2016 17:03
@collinjackson
refactor into js and mojo implementations
f8b7e0a
@collinjackson
Initial stub MojoFirebase implementation
ce90692
@collinjackson
Implement some basic functionality in Mojo
a9a5867
@collinjackson
Remove redundant comments from js implementation file
5877cbc
@collinjackson
Support for value events
46005fd
@collinjackson
Dart-side support for setValue
a64e5bf
@collinjackson
For our fork at least, mojo should be the default implementation.
a8bcdb4 
Once conditional imports are a thing, we can merge the repos.
@collinjackson
Teach the package to register the mojo service it uses
317403f
@collinjackson
Implement authWithPassword and authWithOAuthToken
bb9f852
@collinjackson
Refactor shared code into _getAuthCallback
72bb72c
@collinjackson
Dart-side client implementations of several ::firebase::Firebase Mojo…
c25f22e 
… APIs
@collinjackson
Support for child events
b25fd73
@collinjackson
Update README.md
06e31df
@collinjackson
Update README.md
61148f7
@collinjackson
Update README.md
4186ad5
@collinjackson
Update README.md
1a29758
@collinjackson
Update version
21de01e
@collinjackson
Fix type errors
9c16a5b
@mpcomplete @collinjackson
Update config.yaml to match new flutter tool.
e909f72
@tvolkert @collinjackson
Rev engine
ed2c843
@tvolkert @collinjackson
Rev engine
a0b6363
@chinmaygarde @collinjackson
Add iOS universal dylib
43c0534
@collinjackson
Copy link
Author

Closing as mojo is no longer used in Flutter.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Flutter support
6 participants
@collinjackson @davenotik @sethladd @mpcomplete @tvolkert @chinmaygarde