Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core(i18n): reframe the ICU message descriptions with placeholders #5737

Merged
merged 1 commit into from
Jul 27, 2018

Conversation

paulirish
Copy link
Member

First, a word from the docs:

The industry standard, ICU MessageFormat Syntax, is used to format these messages internally. However, only select parts of that syntax work at Google.

lol thx. So #5736 was a waste and doesn't work. So we'll describe the placeholders this way.

Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

However, only select parts of that syntax work at Google.

doh! 🤦‍♂️

lgtm! though I wonder if we should also call out {placehoder}\xa0 as the special thing to not touch just so they don't get thrown by the character code :)

@paulirish paulirish merged commit 56b7fbf into master Jul 27, 2018
@paulirish paulirish deleted the placeholderdescriptions branch July 27, 2018 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants