This repository has been archived by the owner on Aug 9, 2023. It is now read-only.
cu2qu/ufo: must use PointToSegmentPen with outputImpliedClosingLine=True #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When collecting a glyph's segments, we can't simply call the glyphs' draw method with the GetSegmentsPen, but we must initialize the PointToSegmentPen explicitly with outputImpliedClosingLine=True. By default PointToSegmentPen does not outputImpliedClosingLine -- unless last and first point on closed contour are duplicated. Because we are converting multiple glyphs at the same time, we want to make sure the _get_segments function returns the same number of segments, whether or not the last and first point overlap. Fixes googlefonts/fontmake#572 Also see: fonttools/fonttools#1720
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When collecting a glyph's segments, we can't simply call the glyphs' draw method with the GetSegmentsPen, but we must initialize the PointToSegmentPen explicitly with
outputImpliedClosingLine=True.By default PointToSegmentPen does not outputImpliedClosingLine -- unless last and first point on closed contour are duplicated.
Because we are converting multiple glyphs at the same time, we want to make sure the
_get_segmentsfunction returns the same number of segments, whether or not the last and first point overlap.Fixes googlefonts/fontmake#572
Also see: fonttools/fonttools#1720