Skip to content
This repository has been archived by the owner on Aug 9, 2023. It is now read-only.

cu2qu/ufo: must use PointToSegmentPen with outputImpliedClosingLine=True #185

Merged

Commits on Sep 13, 2019

  1. cu2qu/ufo: must use PointToSegmentPen with outputImpliedClosingLine=True

    When collecting a glyph's segments, we can't simply call the glyphs' draw
    method with the GetSegmentsPen, but we must initialize the
    PointToSegmentPen explicitly with outputImpliedClosingLine=True.
    
    By default PointToSegmentPen does not outputImpliedClosingLine -- unless
    last and first point on closed contour are duplicated.
    
    Because we are converting multiple glyphs at the same time, we want to
    make sure the _get_segments function returns the same number of segments,
    whether or not the last and first point overlap.
    
    Fixes googlefonts/fontmake#572
    
    Also see: fonttools/fonttools#1720
    anthrotype committed Sep 13, 2019
    Configuration menu
    Copy the full SHA
    855166c View commit details
    Browse the repository at this point in the history