replace fontmake.instantiator with ufo2ft.instantiator #1081
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
force-pushed
the
remove-instantiator
branch
3 times, most recently
from
8e3d1e3
to
aa52e5a
Compare
fontmake.instantiator module now lives in ufo2ft.instantiator; the current fontmake.instantiator is kept as a stub that re-exports the symbol from ufo2ft.instantiator for backward compatibility. Also kept the test_instantiator.py to make sure it continues to work unchanged. The attrs dependency is no longer needed, since ufo2ft.instantiator uses dataclasses, so I removed it from fontmake's direct dependencies (it's still used indirectly in ufoLib2, which fontmake depends on).
anthrotype
force-pushed
the
remove-instantiator
branch
from
aa52e5a
to
13dd5b3
Compare
|
test fails because it needs googlefonts/glyphsLib#992, need to first do a glyphsLib release.. |
anthrotype
force-pushed
the
remove-instantiator
branch
from
f6f5a2a
to
9a971f8
Compare
anthrotype
force-pushed
the
remove-instantiator
branch
from
9a971f8
to
d956957
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fontmake.instantiator module now lives in ufo2ft.instantiator (googlefonts/ufo2ft#825); the current fontmake.instantiator module is kept as a stub that re-exports the symbols from the new ufo2ft.instantiator for backward compatibility. I also kept the test_instantiator.py to make sure it continues to work unchanged.
The attrs dependency is no longer needed, since ufo2ft.instantiator uses dataclasses, so I removed it from fontmake's direct dependencies (it's still used indirectly in ufoLib2, which fontmake depends on).