Copy/move fontmake.instantiator module to ufo2ft.instantiator #825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anthrotype
force-pushed
the
fm-instantiator
branch
3 times, most recently
from
cb6c188
to
6c19ed3
Compare
anthrotype
force-pushed
the
fm-instantiator
branch
2 times, most recently
from
3dd47cb
to
1af2b87
Compare
anthrotype
force-pushed
the
fm-instantiator
branch
2 times, most recently
from
b9211dc
to
9301436
Compare
…es; allow to only process glyphs (no info/kerning)
…d36d210f89b5e8d537c3f6
anthrotype
force-pushed
the
fm-instantiator
branch
from
9301436
to
db6f49f
Compare
madig
approved these changes
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to be able to generate instances of glyphs on the fly to be able to correctly decomposing composite glyphs that are defined at different locations than some of their component glyphs (context googlefonts/glyphsLib#954).
We already have code inside fontmake to generate instance UFOs (using fontMath and fontTools.varLib). So I asked its author Nikolaus @madig if we can copy it over here in ufo2ft and he said it's fine as long as it continues to work unchanged.
So this PR simply copies the fontmake.instantiator module as it currently is (as of Thursday 14 March 2024, at commit googlefonts/fontmake@0971eb0) along with its tests.
I also modified it slightly in order to be able to run it on either ufoLib2 or defcon fonts.
In follow up PRs I will use this to implement the decomposition of interpolatable composite glyphs.