Use MathGlyph's "strict" flag #962
Conversation
This fixes googlefonts#961, and makes instantiator.py as strict as varLib when interpolating. Depends on robotools/fontMath#305, though, as fontMath doesn't properly propagate its "strict" flag down to copies. So this PR should probably also update its fontMath version dependency, once a new fontMath is out.
|
ideally we also add a test perhaps based on the one from #961 |
|
That failing lint check seems to demand passing the Not sure what to do about that in the context of this PR. |
|
for now, we need to mute that overly zealous flake8 warning with googlefonts/ufo2ft#684 |
|
i'm fine if you do that within this same PR, thanks! |
|
oh jeez, codecov is haunting us again here.. ignore it for now, I can fix it on main |
|
@justvanrossum do you mind if I merge as is? I can fix the unrelated CI failures on main afterwards |
|
Oh I just added a test! Sure, I'm fine with merging if you consider it fine. |
|
can you please rebase on main? I think I fixed both flake8 and codecov issues |
justvanrossum
force-pushed
the
patch-1
branch
from
c28173f
to
ee91075
Compare
|
just pushed v3.5.1 tag 👍 |
This fixes #961, and makes instantiator.py as strict as varLib when interpolating.
Depends on robotools/fontMath#305, though, as fontMath doesn't properly propagate its "strict" flag down to copies.
So this PR should probably also update its fontMath version dependency, once a new fontMath is out.