-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass flags down when copying the data #305
Conversation
(Sorry, I don't understand the test failure) |
This fixes googlefonts#961, and makes instantiator.py as strict as varLib when interpolating. Depends on robotools/fontMath#305, though, as fontMath doesn't properly propagate its "strict" flag down to copies. So this PR should probably also update its fontMath version dependency, once a new fontMath is out.
maybe it's sufficient that you rename "py.test" -> "pytest" in Lines 13 to 16 in 678c071
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, pending CI goes green again
So copies can also be "strict".
1a2f72e
to
d4b7b03
Compare
Rebased on master, CI should now pass. |
thanks, feel free to merge. I don't know how releases work here, so I'd leave that to you or Ben |
Codecov Report
@@ Coverage Diff @@
## master #305 +/- ##
=======================================
Coverage 89.00% 89.00%
=======================================
Files 12 12
Lines 2338 2338
Branches 301 301
=======================================
Hits 2081 2081
Misses 189 189
Partials 68 68
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Should I ask what this was about? |
MathGlyph has a |
context is googlefonts/fontmake#961 and googlefonts/fontmake#962 |
...which in turn causes off-curve points that coincide with on-curve points to be deleted as part of the "filter redundant points" step, which breaks interpolation compatibility. See also googlefonts/fontmake#961 |
It was more about |
@justvanrossum @anthrotype: I worked on the early strict stuff. I did not look at |
no worries! thanks |
So copies can also be "strict".