-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add customizable shortcuts panel #1636
Conversation
…ode + commandKey changes
… instead of tooltip
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't a proper review yet, I just noticed some small things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two more small things.
Co-authored-by: Just van Rossum <justvanrossum@gmail.com>
Co-authored-by: Just van Rossum <justvanrossum@gmail.com>
I noticed that if you assign a shortcut to the ellipse tool, the tool will switch, but the icon doesn't. This is technically unrelated to this PR, but perhaps it stll makes sense to fix it here. |
Co-authored-by: Just van Rossum <justvanrossum@gmail.com>
I agree. I fixed it here already: https://github.com/googlefonts/fontra/pull/1604/files |
Ah, but that PR got merged into a branch which is now abandoned, right? |
yes. |
Co-authored-by: Just van Rossum <justvanrossum@gmail.com>
This fixes #1594, fixes #1589, fixes #721, and fixes #1642.
Known issues:
event.preventDefault()
does not work for default shortcuts like cmd+N (event.stopImmediatePropagation() does not work either)-> some default shortcuts cannot be overwritten, please see: bugs.chromium
-> Good comment related to this issue