Code

Add customizable shortcuts panel#1636

Code

Merged

justvanrossum merged 122 commits intomaingooglefonts/fontra:mainfrom issue-1594-custom-shortcutsgooglefonts/fontra:issue-1594-custom-shortcutsCopy head branch name to clipboardSep 17, 2024

+932-97

Commits

Commits on Sep 3, 2024

• Copy some code from other branch (because of many changes made meanwhile to main)

  ollimeier

  committed
  9628d26

  Copy full SHA for 9628d26

• Add translation for new panel titles

  ollimeier

  committed
  556cd79

  Copy full SHA for 556cd79

• Extend shortCutKeyMap + extend getShortCutRepresentation with missing keys

  ollimeier

  committed
  c250701

  Copy full SHA for c250701

• Refactoring panel-shortcuts

  ollimeier

  committed
  e457e5f

  Copy full SHA for e457e5f

• Further refactoring

  ollimeier

  committed
  f49da2e

  Copy full SHA for f49da2e

• commit current stage of refactoring

  ollimeier

  committed
  1da05e6

  Copy full SHA for 1da05e6

• Show shortcuts with nice labels in panel-shortcuts.js

  ollimeier

  committed
  a41d9a6

  Copy full SHA for a41d9a6

• Use getActionTitle instead of translate if required.

  ollimeier

  committed
  33068fb

  Copy full SHA for 33068fb

• Refactoring parts related to previous keysOrCodes which is now keyOrCode + commandKey changes

  ollimeier

  committed
  4b30927

  Copy full SHA for 4b30927

Commits on Sep 4, 2024

• Fix issue with actionsByKeyOrCode by using shortCutHandleKey instead

  ollimeier

  committed
  ad1559f

  Copy full SHA for ad1559f

• Remove unused setupUI from ShortCutElement + use title for text input instead of tooltip

  ollimeier

  committed
  4f5615b

  Copy full SHA for 4f5615b

• Remove specific replacement for "menubar.view.find-glyphs-that-use"

  ollimeier

  committed
  299728f

  Copy full SHA for 299728f

• Fix typo and some variable names

  ollimeier

  committed
  1b65de3

  Copy full SHA for 1b65de3

• fix issue: keyOrCode should not be an array

  ollimeier

  committed
  c9dd788

  Copy full SHA for c9dd788

• Refactor: getShortCutHandleKey

  ollimeier

  committed
  2c8bd2e

  Copy full SHA for 2c8bd2e

• Fix resetShortCut

  ollimeier

  committed
  ee7eec6

  Copy full SHA for ee7eec6

Commits on Sep 5, 2024

• Update src/fontra/client/lang/en.json

  Show description for 635510d
  

  ollimeier

  and

  justvanrossum

  authored
  635510d

  Copy full SHA for 635510d

• Update src/fontra/views/applicationsettings/panel-shortcuts.js

  Show description for 77b3211
  

  ollimeier

  and

  justvanrossum

  authored
  77b3211

  Copy full SHA for 77b3211

• Update src/fontra/views/applicationsettings/panel-shortcuts.js

  Show description for f792f9a
  

  ollimeier

  and

  justvanrossum

  authored
  f792f9a

  Copy full SHA for f792f9a

• Fix icon-button with missing import.

  ollimeier

  committed
  c38cc04

  Copy full SHA for c38cc04

• Undo changes related to actionsByKeyOrCode

  ollimeier

  committed
  072c683

  Copy full SHA for 072c683

• Fix label

  ollimeier

  committed
  15309ec

  Copy full SHA for 15309ec

• Add isMac to utils

  ollimeier

  committed
  f2946d4

  Copy full SHA for f2946d4

• rework shortCutKeyMap

  ollimeier

  committed
  061ae6a

  Copy full SHA for 061ae6a

• 'Clear' instead of 'Delete' (tooltip)

  ollimeier

  committed
  f0a24f9

  Copy full SHA for f0a24f9

• Remove .clipboard from actionIdentifier + remove titleKey

  ollimeier

  committed
  35fefd6

  Copy full SHA for 35fefd6

• Fix failing test

  ollimeier

  committed
  d83c093

  Copy full SHA for d83c093

• small refactoring of isMac

  ollimeier

  committed
  fdc5b22

  Copy full SHA for fdc5b22

• Fix issue if shortcut is undefined/null

  ollimeier

  committed
  521c70f

  Copy full SHA for 521c70f

• Further use of shortCutModifierMap

  ollimeier

  committed
  d34f6be

  Copy full SHA for d34f6be

• Refactor code, eg. remove parseShortCutString

  ollimeier

  committed
  b2118f1

  Copy full SHA for b2118f1

• Remove unused swappedKeyMap

  ollimeier

  committed
  337ed45

  Copy full SHA for 337ed45

• Refactoring: eg. different variable names + use event.keyCode

  ollimeier

  committed
  45e9a73

  Copy full SHA for 45e9a73

• Add sortIndex to actions for better shortcut sorting

  ollimeier

  committed
  1e067ef

  Copy full SHA for 1e067ef

• "Delete" instead of "Delete Glyph/Selection"

  ollimeier

  committed
  6a51a44

  Copy full SHA for 6a51a44

• Move sorting to getActionIdentifiers

  ollimeier

  committed
  15ca2e3

  Copy full SHA for 15ca2e3

• Some formatting

  ollimeier

  committed
  612a315

  Copy full SHA for 612a315

Commits on Sep 9, 2024

• Copy some code from other branch (because of many changes made meanwhile to main)

  

  ollimeier

  authored and

  justvanrossum

  committed
  ce20318

  Copy full SHA for ce20318

• Add translation for new panel titles

  

  ollimeier

  authored and

  justvanrossum

  committed
  c651e31

  Copy full SHA for c651e31

• Extend shortCutKeyMap + extend getShortCutRepresentation with missing keys

  

  ollimeier

  authored and

  justvanrossum

  committed
  9f1579e

  Copy full SHA for 9f1579e

• Refactoring panel-shortcuts

  

  ollimeier

  authored and

  justvanrossum

  committed
  6c88234

  Copy full SHA for 6c88234

• Further refactoring

  

  ollimeier

  authored and

  justvanrossum

  committed
  43d8852

  Copy full SHA for 43d8852

• commit current stage of refactoring

  

  ollimeier

  authored and

  justvanrossum

  committed
  3ca5357

  Copy full SHA for 3ca5357

• Show shortcuts with nice labels in panel-shortcuts.js

  

  ollimeier

  authored and

  justvanrossum

  committed
  846f6fb

  Copy full SHA for 846f6fb

• Use getActionTitle instead of translate if required.

  

  ollimeier

  authored and

  justvanrossum

  committed
  6ebb57b

  Copy full SHA for 6ebb57b

• Refactoring parts related to previous keysOrCodes which is now keyOrCode + commandKey changes

  

  ollimeier

  authored and

  justvanrossum

  committed
  d4c2166

  Copy full SHA for d4c2166

• Fix issue with actionsByKeyOrCode by using shortCutHandleKey instead

  

  ollimeier

  authored and

  justvanrossum

  committed
  f06541b

  Copy full SHA for f06541b

• Remove unused setupUI from ShortCutElement + use title for text input instead of tooltip

  

  ollimeier

  authored and

  justvanrossum

  committed
  9aae5ad

  Copy full SHA for 9aae5ad

• Remove specific replacement for "menubar.view.find-glyphs-that-use"

  

  ollimeier

  authored and

  justvanrossum

  committed
  18685cb

  Copy full SHA for 18685cb

• Fix typo and some variable names

  

  ollimeier

  authored and

  justvanrossum

  committed
  377eb65

  Copy full SHA for 377eb65

• fix issue: keyOrCode should not be an array

  

  ollimeier

  authored and

  justvanrossum

  committed
  ecadda6

  Copy full SHA for ecadda6

• Refactor: getShortCutHandleKey

  

  ollimeier

  authored and

  justvanrossum

  committed
  294cc1d

  Copy full SHA for 294cc1d

• Fix resetShortCut

  

  ollimeier

  authored and

  justvanrossum

  committed
  1c1963f

  Copy full SHA for 1c1963f

• Update src/fontra/client/lang/en.json

  Show description for 3555955
  

  ollimeier

  and

  justvanrossum

  committed
  3555955

  Copy full SHA for 3555955

• Update src/fontra/views/applicationsettings/panel-shortcuts.js

  Show description for e3ee3c0
  

  ollimeier

  and

  justvanrossum

  committed
  e3ee3c0

  Copy full SHA for e3ee3c0

• Update src/fontra/views/applicationsettings/panel-shortcuts.js

  Show description for 8d700a4
  

  ollimeier

  and

  justvanrossum

  committed
  8d700a4

  Copy full SHA for 8d700a4

• Fix icon-button with missing import.

  

  ollimeier

  authored and

  justvanrossum

  committed
  cde983c

  Copy full SHA for cde983c

• Undo changes related to actionsByKeyOrCode

  

  ollimeier

  authored and

  justvanrossum

  committed
  1a2eae5

  Copy full SHA for 1a2eae5

• Fix label

  

  ollimeier

  authored and

  justvanrossum

  committed
  1a94807

  Copy full SHA for 1a94807

• Add isMac to utils

  

  ollimeier

  authored and

  justvanrossum

  committed
  4614a30

  Copy full SHA for 4614a30

• rework shortCutKeyMap

  

  ollimeier

  authored and

  justvanrossum

  committed
  4216af6

  Copy full SHA for 4216af6

• 'Clear' instead of 'Delete' (tooltip)

  

  ollimeier

  authored and

  justvanrossum

  committed
  96c2082

  Copy full SHA for 96c2082

• Remove .clipboard from actionIdentifier + remove titleKey

  

  ollimeier

  authored and

  justvanrossum

  committed
  4605bd3

  Copy full SHA for 4605bd3

• Fix failing test

  

  ollimeier

  authored and

  justvanrossum

  committed
  16c8df7

  Copy full SHA for 16c8df7

• small refactoring of isMac

  

  ollimeier

  authored and

  justvanrossum

  committed
  a5d901e

  Copy full SHA for a5d901e

• Fix issue if shortcut is undefined/null

  

  ollimeier

  authored and

  justvanrossum

  committed
  d74da25

  Copy full SHA for d74da25

• Further use of shortCutModifierMap

  

  ollimeier

  authored and

  justvanrossum

  committed
  ffa7d53

  Copy full SHA for ffa7d53

• Refactor code, eg. remove parseShortCutString

  

  ollimeier

  authored and

  justvanrossum

  committed
  530fb8b

  Copy full SHA for 530fb8b

• Remove unused swappedKeyMap

  

  ollimeier

  authored and

  justvanrossum

  committed
  788c889

  Copy full SHA for 788c889

• Refactoring: eg. different variable names + use event.keyCode

  

  ollimeier

  authored and

  justvanrossum

  committed
  204d900

  Copy full SHA for 204d900

• Add sortIndex to actions for better shortcut sorting

  

  ollimeier

  authored and

  justvanrossum

  committed
  b087258

  Copy full SHA for b087258

• "Delete" instead of "Delete Glyph/Selection"

  

  ollimeier

  authored and

  justvanrossum

  committed
  38ea4fc

  Copy full SHA for 38ea4fc

• Move sorting to getActionIdentifiers

  

  ollimeier

  authored and

  justvanrossum

  committed
  3eb9df0

  Copy full SHA for 3eb9df0

• Some formatting

  

  ollimeier

  authored and

  justvanrossum

  committed
  ae69e68

  Copy full SHA for ae69e68

• Add helper func getBaseKeyFromKeyEvent()

  justvanrossum

  committed
  2386810

  Copy full SHA for 2386810

Commits on Sep 10, 2024

• Merge branch 'issue-1594-custom-shortcuts' of https://github.com/googlefonts/fontra into issue-1594-custom-shortcuts

  ollimeier

  committed
  9790777

  Copy full SHA for 9790777

• Use "X" icon instead of trash for shortcuts panel

  ollimeier

  committed
  d1d967e

  Copy full SHA for d1d967e

• Move sortIndex logic out of registerAction into registerActionInfo

  ollimeier

  committed
  c3aec9a

  Copy full SHA for c3aec9a

• Change metaKey to commandKey

  ollimeier

  committed
  265c803

  Copy full SHA for 265c803

• Add '|| event.type === "keyup"' to assert because of shortcut recording

  ollimeier

  committed
  64d44e9

  Copy full SHA for 64d44e9

• use getBaseKeyFromKeyEvent in shortcuts panel

  Show description for 04ba2d0
  ollimeier

  committed
  04ba2d0

  Copy full SHA for 04ba2d0

Commits on Sep 11, 2024

• Fix shortcut issue with customShortCuts being null -> should be empty list

  ollimeier

  committed
  fcc6d63

  Copy full SHA for fcc6d63

• sorting refinement

  ollimeier

  committed
  c8d4fbe

  Copy full SHA for c8d4fbe

• Better variable name: keysModel instead of controllers

  ollimeier

  committed
  0b4ab84

  Copy full SHA for 0b4ab84

• Use getBaseKeyFromKeyEvent + rename keyOrCode to baseKey

  ollimeier

  committed
  524cb27

  Copy full SHA for 524cb27

• Delete commented out code

  ollimeier

  committed
  fb48f1f

  Copy full SHA for fb48f1f

• Fix subtools switch (via shortcut)

  ollimeier

  committed
  260ad76

  Copy full SHA for 260ad76

• Extend shortCutKeyMap

  ollimeier

  committed
  4e19703

  Copy full SHA for 4e19703

• Undo change to getActionIdentifiers (as we do the sorting in shortcuts panel)

  ollimeier

  committed
  61b3721

  Copy full SHA for 61b3721

• Remove dialog + refactor dependencies

  ollimeier

  committed
  30ead68

  Copy full SHA for 30ead68

• Use div instead of input for shortcuts

  ollimeier

  committed
  3aa9dbc

  Copy full SHA for 3aa9dbc

• Make icons closer to each other

  ollimeier

  committed
  56ddb5f

  Copy full SHA for 56ddb5f

• adjust shortcut div height style

  ollimeier

  committed
  aeaffe6

  Copy full SHA for aeaffe6

• Some minor refactoring

  ollimeier

  committed
  5cc375d

  Copy full SHA for 5cc375d

• Remove unnecessary key map of FXX keys

  ollimeier

  committed
  46040d8

  Copy full SHA for 46040d8

• Keep focus of shortcut div even if reset or delete icon has been clicked.

  ollimeier

  committed
  51360d0

  Copy full SHA for 51360d0

• minor refactoring

  ollimeier

  committed
  bd9de2c

  Copy full SHA for bd9de2c

Commits on Sep 12, 2024

• Bugfix: pressed modifier key but clicked outside the input field

  ollimeier

  committed
  85b3a7a

  Copy full SHA for 85b3a7a

Commits on Sep 16, 2024

• Register each user-switchable layers as a toggle actions. This implements #1642

  justvanrossum

  committed
  24dd297

  Copy full SHA for 24dd297

Commits on Sep 17, 2024

• Make label wider and wrap

  ollimeier

  committed
  ca76982

  Copy full SHA for ca76982

• Get rid of fromWebSocket() and use start() instead

  ollimeier

  committed
  40a4d2c

  Copy full SHA for 40a4d2c

• Removing unnecessary document.title

  ollimeier

  committed
  3c7a369

  Copy full SHA for 3c7a369

• Removing unused messageFromServer, handleRemoteClose, handleRemoteError

  ollimeier

  committed
  de60ec8

  Copy full SHA for de60ec8

• Removing doUndoRedo, postChange, handleKeyDown

  ollimeier

  committed
  8dec369

  Copy full SHA for 8dec369

• Removing UndoStack and unused imports

  ollimeier

  committed
  dc92318

  Copy full SHA for dc92318

• Merge main into this PR

  justvanrossum

  committed
  33faafa

  Copy full SHA for 33faafa

• Disambiguate Numpad keys

  justvanrossum

  committed
  571beed

  Copy full SHA for 571beed

• remove focus when done

  ollimeier

  committed
  3612010

  Copy full SHA for 3612010

• use 'normal' instead of 'break-spaces'

  ollimeier

  committed
  02acc49

  Copy full SHA for 02acc49

• make shortcuts input width grow and default width a little wider

  ollimeier

  committed
  58e0db8

  Copy full SHA for 58e0db8

• Ensure both shortcuts aren't falsey before we continue

  justvanrossum

  committed
  220d3bb

  Copy full SHA for 220d3bb

• Fix small shift because of focus border

  ollimeier

  committed
  3d7ef59

  Copy full SHA for 3d7ef59

• Hide ServerInfoPanel for now

  ollimeier

  committed
  59cf35d

  Copy full SHA for 59cf35d

• split window.applicationSettingsController into two parts

  ollimeier

  committed
  ca577a5

  Copy full SHA for ca577a5

• Update src/fontra/views/applicationsettings/panel-shortcuts.js

  Show description for 5d02d5b
  

  ollimeier

  and

  justvanrossum

  authored
  5d02d5b

  Copy full SHA for 5d02d5b

• Update language json files

  ollimeier

  committed
  d84b493

  Copy full SHA for d84b493

• Refactor name recordShortCutKeyUp

  ollimeier

  committed
  4b3aadb

  Copy full SHA for 4b3aadb

• Rename outOfFocus to handleOnBlur

  ollimeier

  committed
  85e0205

  Copy full SHA for 85e0205

• make helper function from collapseSubTools

  ollimeier

  committed
  4f83e10

  Copy full SHA for 4f83e10

• ensure actionIdentifier is valid

  ollimeier

  committed
  90cc616

  Copy full SHA for 90cc616

• Refactor startApp

  ollimeier

  committed
  29cf3d4

  Copy full SHA for 29cf3d4

• Rename key to application-settings.server-info.title + use Chinese translation

  ollimeier

  committed
  7379262

  Copy full SHA for 7379262