Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarkFeatureWriter's markClasses inserted after manual mkmk features #504

Closed
simoncozens opened this issue May 28, 2021 · 1 comment
Closed

Comments

@simoncozens
Copy link
Contributor

Investigating notofonts/noto-source#377, I found that NotoLoopedThai.glyphs doesn't compile because it has a manually written mkmk. The automatic mkmk feature is correctly written to the feature file above this, but the mark classes don't appear until afterwards:

feature mkmk {     # THIS IS ufo2ft'S MKMK
    lookup mark2mark_bottomright {
        @MFS_mark2mark_bottomright = [saraU-thai saraU-thai.small saraUu-thai saraUu-thai.small phinthu-thai phinthu_saraU-thai phinthu_saraUu-thai];
        lookupflag UseMarkFilteringSet @MFS_mark2mark_bottomright;
        pos mark saraU-thai
            <anchor 196 -299> mark @MC_bottomright;
...
} mkmk;

feature mkmk {   # THIS IS THE FONT'S MKMK
    lookup combinewithdoublemacron {
        ### move doubleMacron up if preceded by Thai marks above
        pos @ThaiAboveMarks [doublemacroncomb doublemacroncomb.wide]' <0 190 0 0>;
...
} mkmk;

...

markClass macronbelowcomb <anchor 177 0> @MC_bottom;
markClass macronbelowcomb.alt <anchor 0 0> @MC_bottom;
...
feature mark {
    lookup mark2base {
        pos base koKai-thai
            <anchor 276 0> mark @MC_bottom
            <anchor 466 0> mark @MC_bottomright
...

Looks like ufo2ft is assuming that mark will always appear first.

@anthrotype
Copy link
Member

closing as fixed by #505

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants