Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find earliest opportunity to insert lookups/mark classes/anchors #505

Merged
merged 1 commit into from
Jun 30, 2021
Merged

Find earliest opportunity to insert lookups/mark classes/anchors #505

merged 1 commit into from
Jun 30, 2021

Conversation

simoncozens
Copy link
Contributor

Potential fix for #504

anthrotype
anthrotype reviewed Jun 29, 2021
View reviewed changes
Copy link
Member

@anthrotype anthrotype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it would be nice to have an accompanying test

@anthrotype anthrotype requested a review from moyogo June 29, 2021 15:15
@moyogo moyogo merged commit 0a4b703 into googlefonts:main Jun 30, 2021
@moyogo
Copy link
Collaborator

moyogo commented Jun 30, 2021

Thanks @simoncozens !

@moyogo
Copy link
Collaborator

moyogo commented Jun 30, 2021

I added a test in 86c3357

@simoncozens
Copy link
Contributor Author

Thank you!

@anthrotype anthrotype mentioned this pull request Jul 7, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anthrotype anthrotype anthrotype left review comments

@moyogo moyogo Awaiting requested review from moyogo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simoncozens @moyogo @anthrotype