Fix sdk-server image make target #1200

aLekSer · 2019-12-03T17:55:51Z

SDK sidecar image is used to run conformance tests against it.
Fix for make run-sdk-conformance-local in particular.

Closes #1199.

agones-bot · 2019-12-03T18:08:26Z

Build Succeeded 👏

Build Id: 23bc0136-0820-4025-b91d-f8fa7fda8d91

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-8f2d79e
image: gcr.io/agones-images/agones-sdk:1.2.0-8f2d79e
image: gcr.io/agones-images/agones-ping:1.2.0-8f2d79e
Linux C++ SDK (build): agonessdk-1.2.0-8f2d79e-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-8f2d79e.zip

A preview of the website (the last 30 builds are retained):

https://8f2d79e-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1200/head:pr_1200 && git checkout pr_1200
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-8f2d79e

agones-bot · 2019-12-03T18:23:49Z

Build Succeeded 👏

Build Id: 8859da68-0c27-4ef6-9d16-287e81320877

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-6115049
image: gcr.io/agones-images/agones-sdk:1.2.0-6115049
image: gcr.io/agones-images/agones-ping:1.2.0-6115049
Linux C++ SDK (build): agonessdk-1.2.0-6115049-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-6115049.zip

A preview of the website (the last 30 builds are retained):

https://6115049-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1200/head:pr_1200 && git checkout pr_1200
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-6115049

markmandel · 2019-12-03T22:05:16Z

build/Makefile

@@ -124,7 +124,7 @@ ifdef NO_RACE_DETECTOR
  RACE_DETECTOR_ARGS=
 endif

-go_test_cmd = go test -mod=vendor $(RACE_DETECTOR_ARGS)
+go_test_cmd = go test -mod=vendor $(RACE_DETECTOR_ARGS) -v -run TestPingHTTP


Was this left in by accident? Doesn't this limit what tests are run?

Resolved, sorry, was fixing this test which is failing on make kind-test-e2e

markmandel · 2019-12-04T02:35:45Z

FYI, release delayed until tomorrow, so we can likely get this one in.

SDK sidecar image is used to run conformance tests against it. Fix for make run-sdk-conformance-local in particular.

agones-bot · 2019-12-04T05:40:38Z

Build Failed 😱

Build Id: 019f69b5-b008-4e98-b9e6-cf078c151864

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-12-04T05:45:23Z

Build Succeeded 👏

Build Id: 3e86df99-5f8e-4f5f-bc61-7b2039d64c10

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-8199e0b
image: gcr.io/agones-images/agones-sdk:1.2.0-8199e0b
image: gcr.io/agones-images/agones-ping:1.2.0-8199e0b
Linux C++ SDK (build): agonessdk-1.2.0-8199e0b-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-8199e0b.zip

A preview of the website (the last 30 builds are retained):

https://8199e0b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1200/head:pr_1200 && git checkout pr_1200
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-8199e0b

markmandel

LGTM!

google-oss-robot · 2019-12-04T17:56:10Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aLekSer, markmandel

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [markmandel]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

google-oss-robot · 2019-12-04T17:56:13Z

New changes are detected. LGTM label has been removed.

agones-bot · 2019-12-04T18:09:26Z

Build Succeeded 👏

Build Id: 3dc7f49c-b264-4208-bae1-73ee9e3e5277

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:1.2.0-d0fd558
image: gcr.io/agones-images/agones-sdk:1.2.0-d0fd558
image: gcr.io/agones-images/agones-ping:1.2.0-d0fd558
Linux C++ SDK (build): agonessdk-1.2.0-d0fd558-linux-arch_64.tar.gz
SDK Server: agonessdk-server-1.2.0-d0fd558.zip

A preview of the website (the last 30 builds are retained):

https://d0fd558-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1200/head:pr_1200 && git checkout pr_1200
helm install ./install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.2.0-d0fd558

SDK sidecar image is used to run conformance tests against it. Fix for make run-sdk-conformance-local in particular.

google-oss-robot added the size/XS label Dec 3, 2019

google-oss-robot requested review from dzlier-gcp and pooneh-m December 3, 2019 17:56

aLekSer force-pushed the fix/sdk-conformance-target branch from 8f2d79e to 6115049 Compare December 3, 2019 18:11

markmandel reviewed Dec 3, 2019

View reviewed changes

aLekSer force-pushed the fix/sdk-conformance-target branch from 6115049 to 12361ef Compare December 4, 2019 05:26

Fix sdk-server image make target

8199e0b

SDK sidecar image is used to run conformance tests against it. Fix for make run-sdk-conformance-local in particular.

aLekSer force-pushed the fix/sdk-conformance-target branch from 12361ef to 8199e0b Compare December 4, 2019 05:28

markmandel approved these changes Dec 4, 2019

View reviewed changes

google-oss-robot assigned markmandel Dec 4, 2019

google-oss-robot added the lgtm label Dec 4, 2019

Merge branch 'master' into fix/sdk-conformance-target

d0fd558

google-oss-robot added approved and removed lgtm labels Dec 4, 2019

markmandel added area/build-tools Development tooling. I.e. pretty much everything in the `build` directory. kind/cleanup Refactoring code, fixing up documentation, etc lgtm labels Dec 4, 2019

markmandel added this to the 1.2.0 milestone Dec 4, 2019

markmandel merged commit 3ac6978 into googleforgames:master Dec 4, 2019

ilkercelikyilmaz pushed a commit to ilkercelikyilmaz/agones that referenced this pull request Oct 23, 2020

Fix sdk-server image make target (googleforgames#1200)

8d7131f

SDK sidecar image is used to run conformance tests against it. Fix for make run-sdk-conformance-local in particular.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix sdk-server image make target #1200

Fix sdk-server image make target #1200

aLekSer commented Dec 3, 2019

agones-bot commented Dec 3, 2019

agones-bot commented Dec 3, 2019

markmandel Dec 3, 2019

aLekSer Dec 4, 2019

markmandel commented Dec 4, 2019

agones-bot commented Dec 4, 2019

agones-bot commented Dec 4, 2019

markmandel left a comment

google-oss-robot commented Dec 4, 2019

google-oss-robot commented Dec 4, 2019

agones-bot commented Dec 4, 2019

Fix sdk-server image make target #1200

Fix sdk-server image make target #1200

Conversation

aLekSer commented Dec 3, 2019

agones-bot commented Dec 3, 2019

agones-bot commented Dec 3, 2019

markmandel Dec 3, 2019

Choose a reason for hiding this comment

aLekSer Dec 4, 2019

Choose a reason for hiding this comment

markmandel commented Dec 4, 2019

agones-bot commented Dec 4, 2019

agones-bot commented Dec 4, 2019

markmandel left a comment

Choose a reason for hiding this comment

google-oss-robot commented Dec 4, 2019

google-oss-robot commented Dec 4, 2019

agones-bot commented Dec 4, 2019