Add feature gate block to Make install #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can test feature gated features, adding a config option to set feature flags, and setting it to enable the currently available feature flags.
markmandel
added
kind/feature
|
Build Failed 😱 Build Id: 59484999-2b0e-41ff-9467-7ee6cba8fa4e To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
|
Build Succeeded 👏 Build Id: ea64becb-0db6-41b0-99a5-b389a9ce3ed6 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Mar 7, 2020
This PR doesn't complete this functionality, but was enough to warrant review. It does two things: 1. The refactoring to move alpha and beta SDK Server implementations into the same file as the main SDK Server, as being able to reuse the current logic made sense on review. 2. Initial Implementation of SDK GetPlayerCapacity & SetPlayerCapacity methods with unit tests. E2E tests can be implemented once googleforgames#1397 is resolved. Next steps will be to implement the local SDK functionality, and conformance tests for Go for these two functions.
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Mar 7, 2020
This PR doesn't complete this functionality, but was enough to warrant review. It does two things: 1. The refactoring to move alpha and beta SDK Server implementations into the same file as the main SDK Server, as being able to reuse the current logic made sense on review. 2. Initial Implementation of SDK GetPlayerCapacity & SetPlayerCapacity methods with unit tests. E2E tests can be implemented once googleforgames#1397 is resolved. Next steps will be to implement the local SDK functionality, and conformance tests for Go for these two functions.
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Mar 7, 2020
This PR doesn't complete this functionality, but was enough to warrant review. It does two things: 1. The refactoring to move alpha and beta SDK Server implementations into the same file as the main SDK Server, as being able to reuse the current logic made sense on review. 2. Initial Implementation of SDK GetPlayerCapacity & SetPlayerCapacity methods with unit tests. E2E tests can be implemented once googleforgames#1397 is resolved. Next steps will be to implement the local SDK functionality, and conformance tests for Go for these two functions. Work on googleforgames#1033
roberthbailey
approved these changes
Mar 14, 2020
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: markmandel, roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
New changes are detected. LGTM label has been removed. |
|
Build Succeeded 👏 Build Id: 14223020-4e52-4043-b149-c3346f1ef8ff The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Mar 26, 2020
This PR doesn't complete this functionality, but was enough to warrant review. It does two things: 1. The refactoring to move alpha and beta SDK Server implementations into the same file as the main SDK Server, as being able to reuse the current logic made sense on review. 2. Initial Implementation of SDK GetPlayerCapacity & SetPlayerCapacity methods with unit tests. E2E tests can be implemented once googleforgames#1397 is resolved. Next steps will be to implement the local SDK functionality, and conformance tests for Go for these two functions. Work on googleforgames#1033
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Mar 31, 2020
This PR doesn't complete this functionality, but was enough to warrant review. It does two things: 1. The refactoring to move alpha and beta SDK Server implementations into the same file as the main SDK Server, as being able to reuse the current logic made sense on review. 2. Initial Implementation of SDK GetPlayerCapacity & SetPlayerCapacity methods with unit tests. E2E tests can be implemented once googleforgames#1397 is resolved. Next steps will be to implement the local SDK functionality, and conformance tests for Go for these two functions. Work on googleforgames#1033
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Mar 31, 2020
This PR doesn't complete this functionality, but was enough to warrant review. It does two things: 1. The refactoring to move alpha and beta SDK Server implementations into the same file as the main SDK Server, as being able to reuse the current logic made sense on review. 2. Initial Implementation of SDK GetPlayerCapacity & SetPlayerCapacity methods with unit tests. E2E tests can be implemented once googleforgames#1397 is resolved. Next steps will be to implement the local SDK functionality, and conformance tests for Go for these two functions. Work on googleforgames#1033
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Mar 31, 2020
This PR doesn't complete this functionality, but was enough to warrant review. It does two things: 1. The refactoring to move alpha and beta SDK Server implementations into the same file as the main SDK Server, as being able to reuse the current logic made sense on review. 2. Initial Implementation of SDK GetPlayerCapacity & SetPlayerCapacity methods with unit tests. E2E tests can be implemented once googleforgames#1397 is resolved. Next steps will be to implement the local SDK functionality, and conformance tests for Go for these two functions. Work on googleforgames#1033
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Mar 31, 2020
This PR doesn't complete this functionality, but was enough to warrant review. It does two things: 1. The refactoring to move alpha and beta SDK Server implementations into the same file as the main SDK Server, as being able to reuse the current logic made sense on review. 2. Initial Implementation of SDK GetPlayerCapacity & SetPlayerCapacity methods with unit tests. E2E tests can be implemented once googleforgames#1397 is resolved. Next steps will be to implement the local SDK functionality, and conformance tests for Go for these two functions. Work on googleforgames#1033
markmandel
added a commit
that referenced
this pull request
Mar 31, 2020
This PR doesn't complete this functionality, but was enough to warrant review. It does two things: 1. The refactoring to move alpha and beta SDK Server implementations into the same file as the main SDK Server, as being able to reuse the current logic made sense on review. 2. Initial Implementation of SDK GetPlayerCapacity & SetPlayerCapacity methods with unit tests. E2E tests can be implemented once #1397 is resolved. Next steps will be to implement the local SDK functionality, and conformance tests for Go for these two functions. Work on #1033
markmandel
added a commit
to markmandel/agones
that referenced
this pull request
Mar 31, 2020
This PR doesn't complete this functionality, but was enough to warrant review. It does two things: 1. The refactoring to move alpha and beta SDK Server implementations into the same file as the main SDK Server, as being able to reuse the current logic made sense on review. 2. Initial Implementation of SDK GetPlayerCapacity & SetPlayerCapacity methods with unit tests. E2E tests can be implemented once googleforgames#1397 is resolved. Next steps will be to implement the local SDK functionality, and conformance tests for Go for these two functions. Work on googleforgames#1033
ilkercelikyilmaz
pushed a commit
to ilkercelikyilmaz/agones
that referenced
this pull request
Oct 23, 2020
So we can test feature gated features, adding a config option to set feature flags, and setting it to enable the currently available feature flags.
ilkercelikyilmaz
pushed a commit
to ilkercelikyilmaz/agones
that referenced
this pull request
Oct 23, 2020
This PR doesn't complete this functionality, but was enough to warrant review. It does two things: 1. The refactoring to move alpha and beta SDK Server implementations into the same file as the main SDK Server, as being able to reuse the current logic made sense on review. 2. Initial Implementation of SDK GetPlayerCapacity & SetPlayerCapacity methods with unit tests. E2E tests can be implemented once googleforgames#1397 is resolved. Next steps will be to implement the local SDK functionality, and conformance tests for Go for these two functions. Work on googleforgames#1033
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So we can test feature gated features, adding a config option to set feature flags, and setting it to enable the currently available feature flags.