QuadTree.remove NullPointerException

[xsorifc28]

Summary:

NPE when items being removed from cluster.

Steps to reproduce:

Random, cannot quantify.

Expected behavior:

Remove item from cluster.

Observed behavior:
Crashes

Device and Android version:

Various phones and API levels between 18-24

Issue:

com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:176)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:171)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:171)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:163)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:171)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:169)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:169)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:165)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:169)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:165)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:163)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:163)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:163)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:169)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:165)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:165)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:169)
com.google.maps.android.quadtree.PointQuadTree.remove (PointQuadTree.java:153)
com.my.package.maps.NonHierarchicalDistanceBasedAlgorithm.removeItem (NonHierarchicalDistanceBasedAlgorithm.java:96)

Not sure why this is happenng, and can't reproduce it, I'm just tracking crash reports from users. Even if mQuadTree is wrapped with !null, still tends to crash.

[philipbjorge]

This occurs when I try and remove items before I've ever inserted into the QuadTree.

[barbeau]

I believe I have a fix for this, I'll open a PR shortly.

[barbeau]

@philipbjorge Thanks for the hint! I opened a PR that should hopefully fix this at #314.