Add PolyUtil.containsLocation(). #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * Returns true if the vertical segment (lat3, lng3) to South Pole intersects the segment | ||
| * (lat1, lng1) to (lat2, lng2). | ||
| */ | ||
| static boolean Intersects(double lat1, double lat2, double lng2, double lat3, double lng3, |
There was a problem hiding this comment.
I would phrase the JavaDoc like this:
Computes whether the vertical segment (lat3, lng3) to South Pole intersects the segment (lat1, lng1) to (lat2, lng2).
Longitudes are offset by -lng1...
Also, lowercase the method (intersects)
|
LGTM, just the one comment on JavaDoc. |
broady
added a commit
that referenced
this pull request
Aug 12, 2013
Add PolyUtil.containsLocation().
|
Thank you, @preda! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.