Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Earth radius. #20

Merged
merged 2 commits into from
Aug 27, 2013
Merged

Update Earth radius. #20

merged 2 commits into from
Aug 27, 2013

Conversation

preda
Copy link

@preda preda commented Aug 22, 2013

WGS-84 ellipsoid model defines an ellipsis with
Major Axis (the Equator), radius = 6378137
Minor axis (Polar), radius = 6356752.3

FAI Sphere radius: 6371000

Mean radius defined by IUGG: 6371009.

The "mean radius" is equal to (2*a + b)/3, a is ecuatorial radius, b is polar radius on the ellipsis model, and apparently minimizes the "ellipsoidal mean square error", so it's a good "mean radius".

@@ -203,10 +203,11 @@ public void testComputeOffsetAndBackToOrigin() {
// arbitrary.
start = SphericalUtil.computeOffsetOrigin(new LatLng(90, 0),
Math.PI * EARTH_RADIUS / 4, 0);
expectLatLngApproxEquals(
if (start != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

broady added a commit that referenced this pull request Aug 27, 2013
Update Earth radius - use the mean radius of the earth instead of radius at equator.
@broady broady merged commit 4800c6f into googlemaps:master Aug 27, 2013
@broady
Copy link
Contributor

broady commented Aug 27, 2013

Thank you.

broady pushed a commit that referenced this pull request Feb 11, 2014
Adding attributions for data set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants