makeIcon takes CharSequence not String

[jonathan-caryl]

The underlying TextView API takes a CharSequence, so this is a simple change that lets us use different fonts etc when creating our icons. I've updated the sample app to show it in use.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

[jonathan-caryl]

I signed it!

[googlebot]

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

[jonathan-caryl]

I'm not sure from the googlebot emails whether it's happy that I've signed the CLA or not: my regular google account I use isn't the email I regularly use for github. I've now added that googlemail account, and after some faffing I've added my github email to that google account. Hopefully that's everything sorted.

[markmcd]

It looks like the problem is that your Git commit uses a different email than the one that signed the CLA. At this point in time I can see that they both point to the same GitHub account, but to make future contributions smoother you can either use a different email on the commit, or add that email to your Google account so googlebot knows who you are.

That aside, contribution looks good, thanks!

[jonathan-caryl]

Sweet. Any timescale for a 0.4.2 release to pick up this change?

[markmcd]

There are a couple of other PRs that only need minor changes before they can be merged - I'll give them a chance to get their changes in and then release 0.4.2.