Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Equals for cluster subclasses #245

Merged
merged 5 commits into from
Feb 21, 2016

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Feb 19, 2016

This is a re-submission of #169 since I no longer have commit access to that one.

For reference, here's the original PR introduction:

Adds implementations of "equals()" and "hashCode()" in StaticCluster and QuadItem classes. Benefit is the ability to reliably compare (and identify) instances of those classes.

As a bonus (and an implicit way to test QuadItem::hashCode() without exposing the inner class) this PR also includes an implementation of NonHierarchicalDistanceBasedAlgorithm::removeItem(). By the way, this would effectively fix issue #133.

PR commits include relevant tests. Let me know if more testing should be added.

Also, the added test files are new and thus copyrighted after myself, but still under the Apache v2 license. Let me know if this needs to be revised somehow.

Cheers!

Let me know if this causes any problems. Thanks!

@hypest
Copy link
Contributor Author

hypest commented Feb 19, 2016

It seems that the build is failing in Travis but not for reasons related to the changes themselves:

Execution failed for task ':library:connectedDebugAndroidTest'.
com.android.builder.testing.api.TestException: com.android.builder.testing.api.DeviceException: com.android.ddmlib.ShellCommandUnresponsiveException

I think re-triggering Travis might give this a chance to succeed. @markmcd would you mind restarting the Travis build on this one? I can try to do it from my side by closing and re-opening this PR but I'll wait for your input first. Thanks!

@markmcd
Copy link
Contributor

markmcd commented Feb 21, 2016

Yes indeed, apologies. Builds are flaky at the moment.

Looks good - thanks again.

markmcd added a commit that referenced this pull request Feb 21, 2016
@markmcd markmcd merged commit aa32533 into googlemaps:master Feb 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants