Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle version bump + updated KML URL for demo. #283

Merged
merged 2 commits into from
Jun 2, 2016

Conversation

stephenmcd
Copy link
Contributor

@markmcd PTAL

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@markmcd
Copy link
Contributor

markmcd commented Jun 1, 2016

LGTM - though it looks like Travis is going to fail when you next merge, so I'd get a fix ready for that before merging this in. Gotta keep that front-page badge green :)

@barbeau
Copy link
Collaborator

barbeau commented Jun 1, 2016

Looks like there are a few things going on with Travis - I have a branch here that should work (container-based execution should be turned off due to memory issues), but it's still failing:
https://travis-ci.org/barbeau/android-maps-utils/builds/134484281

It looks like there was an Android SDK Tools version with a Google APIS emulator that was missing the ABIs - 24.0.2 is what Travis is using, and doing android list targets on Travis shows:

id: 10 or "Google Inc.:Google APIs:23"
     Name: Google APIs
     Type: Add-On
     Vendor: Google Inc.
     Revision: 1
     Description: Android + Google APIs
     Based on Android 6.0 (API level 23)
     Libraries:
      * com.google.android.media.effects (effects.jar)
          Collection of video effects
      * com.android.future.usb.accessory (usb.jar)
          API for USB Accessories
      * com.google.android.maps (maps.jar)
          API for Google Maps
     Skins: HVGA, QVGA, WQVGA400, WQVGA432, WSVGA, WVGA800 (default), WVGA854, WXGA720, WXGA800, WXGA800-7in
 Tag/ABIs : no ABIs.

android list targets on my machine with Android SDK Tools 25.1.7 correctly shows the ABIs:

id: 27 or "Google Inc.:Google APIs:23"
     Name: Google APIs
     Type: Add-On
     Vendor: Google Inc.
     Revision: 1
     Description: Android + Google APIs
     Based on Android 6.0 (API level 23)
     Libraries:
      * com.android.future.usb.accessory (usb.jar)
          API for USB Accessories
      * com.google.android.media.effects (effects.jar)
          Collection of video effects
      * com.google.android.maps (maps.jar)
          API for Google Maps
     Skins: HVGA, QVGA, WQVGA400, WQVGA432, WSVGA, WVGA800 (default), WVGA854, W
XGA720, WXGA800, WXGA800-7in
 Tag/ABIs : google_apis/armeabi-v7a, google_apis/x86, google_apis/x86_64

I don't believe there is a way to force a newer version of SDK Tools on Travis from our .travis.yml script, so I believe we just have to wait for their images to catch up.

@barbeau
Copy link
Collaborator

barbeau commented Jun 1, 2016

Just opened #284 for the Travis-specific issue - I'll post more updates there.

@stephenmcd
Copy link
Contributor Author

Thanks a lot @barbeau - I guess we'll just wait :-)

@stephenmcd stephenmcd merged commit 67702c4 into googlemaps:master Jun 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants