Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Null GeoJson feature properties #289

Merged
merged 2 commits into from
Jun 30, 2016
Merged

Null GeoJson feature properties #289

merged 2 commits into from
Jun 30, 2016

Conversation

stephenmcd
Copy link
Contributor

GeoJson can contain null values, but the parser stored them as the string "null", this fixes that.

@markmcd PTAL

@markmcd
Copy link
Contributor

markmcd commented Jun 29, 2016

Any tests need to be updated? Or added?

If not, LGTM

@stephenmcd
Copy link
Contributor Author

Got a test now in 1681daf

@markmcd
Copy link
Contributor

markmcd commented Jun 30, 2016

LGTM 👍

@stephenmcd stephenmcd merged commit 29c5a69 into googlemaps:master Jun 30, 2016
@stephenmcd stephenmcd deleted the null-geojson-feature-properties branch June 30, 2016 01:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephenmcd @markmcd