Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fall back to linear interpolation when interpolating in short distances (#388) #458

Merged
merged 1 commit into from
Jul 9, 2018

Conversation

eggpi
Copy link
Contributor

@eggpi eggpi commented Jul 7, 2018

Hi, I got affected by issue #388 and thought I'd give the linear interpolation solution a try, since it is suggested in the discussion there (and the Wikipedia article linked in the code), and also seemed to give sensible results after trying it out for a couple of examples. Does this seem like a reasonable approach?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

…es (googlemaps#388).

This also adds a couple of unit tests for interpolating to the beginning
or end of a segment.
@googlebot
Copy link

CLAs look good, thanks!

@stephenmcd
Copy link
Contributor

Great stuff, thank you.

@stephenmcd stephenmcd merged commit 0824b92 into googlemaps:master Jul 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants