-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compiler and lint warnings #53
Conversation
mChildren.add(new PointQuadTree<T>(mBounds.minX, mBounds.midX, mBounds.minY, mBounds.midY, mDepth + 1)); | ||
mChildren.add(new PointQuadTree<T>(mBounds.midX, mBounds.maxX, mBounds.minY, mBounds.midY, mDepth + 1)); | ||
mChildren.add(new PointQuadTree<T>(mBounds.minX, mBounds.midX, mBounds.midY, mBounds.maxY, mDepth + 1)); | ||
mChildren.add(new PointQuadTree<T>(mBounds.midX, mBounds.maxX, mBounds.midY, mBounds.maxY, mDepth + 1)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not convinced this adds very much :)
I think we should at least set the size to 4.
Could you also indent the lines above with spaces instead of tabs?
I updated |
Yes, agree that |
Thank you for all of your contributions! I forgot to ask - have you signed the Google CLA? |
I submitted the request, but haven't received any confirmation (if there is any) |
I don't think there's a confirmation - so, thanks! |
As discussed in #52, I fixed the compiler and build warnings.
Most commits are straight-forward. The changes to
PointQuadTree
andPolyUtil
are covered by unit tests.Notes:
Point
is intentional, so I suppressed the warningPlease have a look, thanks.