Fix #532 - Use ContextCompat to load drawable resources for scaling #571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
barbeau
changed the title
jpoehnelt
approved these changes
Oct 31, 2019
pauminku
added a commit
to pauminku/android-maps-utils
that referenced
this pull request
Nov 26, 2019
* googleOrigin/master: (107 commits) Remove unnecessary interface method public modifiers. (googlemaps#587) Remove unnecessary primitives boxing. (googlemaps#586) Fix googlemaps#575 - Change Travis config, use matrix of API emulators (googlemaps#585) Retain the bitmap cache (googlemaps#381) Made GeoJsonParser with parseGeometry public to use the parser standalone. (googlemaps#492) Fix googlemaps#570 - Use project GitHub URL for remote KML loading demo (googlemaps#581) Bump Gradle plugin for Android Studio v3.5.2 (googlemaps#574) Fix googlemaps#575 - Use API 26 emulator instead of API 28 (googlemaps#576) Fix googlemaps#371 - Run emulator-based unit tests on Travis (googlemaps#573) Fix googlemaps#371 - Run emulator-based unit tests on Travis (googlemaps#573) Fix googlemaps#532 - Use ContextCompat to load drawable resources for scaling (googlemaps#571) Change test methods visibility (googlemaps#569) Release 0.6.2 (googlemaps#568) Demo clustering with ViewModel (googlemaps#506) Differentiate between initial start and configuration change restore (googlemaps#567) Fix wrapping around IDL (googlemaps#564) Update Gradle wrapper to 5.6.3 (googlemaps#566) Add MaxIntensity functionality for user defined intensities on HeatMapTiles (googlemaps#499) Use float zoom to calculate visible bounds (googlemaps#483) Remove apklib publishing (googlemaps#563) ... # Conflicts: # library/src/androidTest/java/com/google/maps/android/PolyUtilTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #532 (comment), it seems the deprecated
Drawable getDrawable (int id)implementation isn't properly handling drawable resource scaling in all cases,This PR replaces the deprecated
Drawable getDrawable (int id)withContextCompat.getDrawable()to hopefully fix the intermittentResources$NotFoundExceptioncrashes during clustering setup.