-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Translate & Modernise google-maps-ios-utils
source & test files. [codecov
- 82.3%] [WIP]
#538
Open
iHackSubhodip
wants to merge
13
commits into
main-swift
Choose a base branch
from
feature/Cluster-QuadTree-Heatmap-Geometry-swift
base: main-swift
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
refactor: Translate & Modernise google-maps-ios-utils
source & test files. [codecov
- 82.3%] [WIP]
#538
iHackSubhodip
wants to merge
13
commits into
main-swift
from
feature/Cluster-QuadTree-Heatmap-Geometry-swift
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anch. (#523) * refactor: Translate & Modernised `GMUCluster` & `GMUClusterItem` class of `Clustering` module. (#491) * refactor: Translate & Modernised `GMUClusterAlgorithm` protocol of `Clustering` module. (#492) * refactor: Translate & Modernise `GMUSimpleClusterAlgorithm` & `GMUStaticCluster` class of `Clustering` module. (#494) * refactor: Translate & Modernise `GMUSimpleClusterAlgorithm` class of `Clustering` module. * refactor: Translate & Modernise `GMUStaticCluster` class of `Clustering` module. * refactor: Update code comments. * refactor: Translate & Modernise `GMUGridBasedClusterAlgorithm`, `GMUStaticClusterTest`(UT) & `GMUTestClusterItem`(Test) class of `Clustering` module. (#495) * refactor: Translate & Modernise `GMUGridBasedClusterAlgorithm` & `GMUTestClusterItem`(Test) class of `Clustering` module. * refactor: Translate & Modernise `GMUStaticClusterTest`(UT) class of `Clustering` module. * refactor: Code comment. * refactor: Translate & Modernised `QuadTree` module. (#489) (#496) * refactor: Refactor & Modernised `QuadTree` module. * refactor: Added Doc descriptions for all the Quad Tree module. * refactor: Code Review comments fix. * refactor: Translate & Modernise `GMUWrappingDictionaryKey` class, `GMUWrappingDictionaryKeyTest`(UT) of `Clustering` module. (#497) * refactor: Translate & Modernise `Clustering` Algorithm module. (#498) * refactor: Translate & Modernise protocols for `Clustering` view module. (#500) * refactor: Translate & Modernise protocols for `Clustering` view module. * refactor `GMUClusterRenderer1` class name. * refactor: Translate & Modernise for `Clustering` view & test module. (#501) * refactor: Translate & Modernise protocols for `Clustering` view module. * refactor `GMUClusterRenderer1` class name. * refactor: Translate & Modernise for `Clustering` view & test module. * refactor: added `NSEC_PER_SEC`. * fix: Add final to `GMUDefaultClusterIconGenerator` class. * refactor: Translate & Modernise `GMUClusterManager` class for `Clustering` module. (#503) * refactor: Translate & Modernise protocols for `Clustering` view module. * refactor `GMUClusterRenderer1` class name. * refactor: Translate & Modernise for `Clustering` view & test module. * refactor: added `NSEC_PER_SEC`. * fix: Add final to `GMUDefaultClusterIconGenerator` class. * refactor: Translate & Modernise `GMUClusterManager` class for `Clustering` module.
…ft` branch. (#524) * refactor: Translate & Modernised `GMUCluster` & `GMUClusterItem` class of `Clustering` module. (#491) * refactor: Translate & Modernised `GMUClusterAlgorithm` protocol of `Clustering` module. (#492) * refactor: Translate & Modernise `GMUSimpleClusterAlgorithm` & `GMUStaticCluster` class of `Clustering` module. (#494) * refactor: Translate & Modernise `GMUSimpleClusterAlgorithm` class of `Clustering` module. * refactor: Translate & Modernise `GMUStaticCluster` class of `Clustering` module. * refactor: Update code comments. * refactor: Translate & Modernise `GMUGridBasedClusterAlgorithm`, `GMUStaticClusterTest`(UT) & `GMUTestClusterItem`(Test) class of `Clustering` module. (#495) * refactor: Translate & Modernise `GMUGridBasedClusterAlgorithm` & `GMUTestClusterItem`(Test) class of `Clustering` module. * refactor: Translate & Modernise `GMUStaticClusterTest`(UT) class of `Clustering` module. * refactor: Code comment. * refactor: Translate & Modernised `QuadTree` module. (#489) (#496) * refactor: Refactor & Modernised `QuadTree` module. * refactor: Added Doc descriptions for all the Quad Tree module. * refactor: Code Review comments fix. * refactor: Translate & Modernise `GMUWrappingDictionaryKey` class, `GMUWrappingDictionaryKeyTest`(UT) of `Clustering` module. (#497) * refactor: Translate & Modernise `Clustering` Algorithm module. (#498) * refactor: Translate & Modernise protocols for `Clustering` view module. (#500) * refactor: Translate & Modernise protocols for `Clustering` view module. * refactor `GMUClusterRenderer1` class name. * refactor: Translate & Modernise `GMUWeightedLatLng` class for `HeatMap` module. (#502) * refactor: Translate & Modernise `GMUGradient` class for `Heatmap` module. (#504) * refactor: Translate & Modernise `GMUWeightedLatLng` class for `HeatMap` module. * refactor: Translate & Modernise `GMUGradient` class for `HeatMap` module. * refactor: Translate & Modernise `GMUHeatmapTileLayer` class for `HeatMap` Module. (#516) * refactor: Translate & Modernise `GMUWeightedLatLng` class for `HeatMap` module. * refactor: Translate & Modernise `GMUGradient` class for `HeatMap` module. * refactor: Translate & Modernise `GMUHeatmapTileLayer` class for `Heatmap` module. * refactor: Unit tests and swift file. * refactor: Modified unit tests. * refactor: code indentation * refactor: Fixed `tileFor` method and unit tests for `GMUHeatmapTileLayer` class.
…eatmap-Geometry-swift` branch. (#525) * refactor(`feature/Geometry-Swift`): Refactored Geometry models & Protocols in swift. (#484) * [Code Commit] Added Geometry models in swift. * refactor(`feature/Geometry-Swift`): Refactored Geometry models & Protocols in swift. * refactor: Refactored `Geometry` models in swift & `optional`/`nullable` properties of the recently committed swift class. (#485) * refactor: Refactored Unit Tests for `Geometry` models in swift. (#486) * refactor: Refactor & Modernised `GMUGeoJSONParser` class of `Geometry` module. (#487) * refactor: Translate & Modernised `GMUKMLParser` class of `Geometry` module. (#490) * refactor: Translate & Modernised `GMUKMLParser` class of `Geometry` module. * refactor: Code Comments modifications. * refactor: Translate & Modernised `GMUGeometryRenderer` class of `Geometry` module. (#508) * refactor: Translate & Modernised `GMUGeometryRenderer` class of `Geometry` module. * refactor: Removed `GMUGeometryRendererTest.swift` class for now.
…-QuadTree-Heatmap-Geometry-swift` branch. (#526) * chore: Clean up Objc files & dependency from `feature/Cluster-QuadTree-Heatmap-Geometry-swift` branch. * chore: Clean up Objc Test bundle & OCMock from Framework
* chore: Add `.xcodeproj` back in the framework. * chore: Add `.xcodeproj` in the root folder. * chore: disable define modules and fix xcode warnings. * chore: Rename Folder & update package.swift extension
…rom Clustering test module. [code cov: 92.4%] (#531)
… test module. [code cov: 100%] (#532)
…class from Clustering test module. [code cov: 78.3%] (#533)
* feat(map): allow custom iconView on GMSMarker subclasses (#506) Previously, when subclassing GMSMarker with a custom iconView, the iconView would not display on the map. This update enables custom iconViews to render correctly when using GMSMarker subclasses. * chore(main): release 6.1.0 (#507) * chore(main): release 6.1.0 * chore(release-please--branches--main): Patch to release branch 6.1.0 (#509) --------- * chore: fixed broken URLs (#515) * chore: update release-please-config.json (#517) Formatting based on https://github.com/googleapis/release-please/blob/main/docs/manifest-releaser.md#configfile * chore: update Simulator and iPhone version in `build.yml` file. * chore: update simulator and iphone version * chore: update xcode version. * chore: Revert OS version. * chore: Update iOS & iPhone Version, revert Xcode version. * chore: Remove use of third party setup-xcode --------- Co-authored-by: Talip BÖKE <talipboke13@gmail.com> Co-authored-by: googlemaps-bot <googlemaps-bot@google.com> Co-authored-by: Enrique López Mañas <eenriquelopez@gmail.com> Co-authored-by: Angela Yu <5506675+wangela@users.noreply.github.com>
…ap-Geometry-swift` # Conflicts: # Sources/GoogleMapsUtilsObjC/include/GMUDefaultClusterRenderer.m
google-maps-ios-utils
source & test files. [codecov
- 82.3%]google-maps-ios-utils
source & test files. [codecov
- 82.3%] [WIP]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's Changing?
google-maps-ios-utils
source & test files.feature/QuadTree-Swift
feature/HeatMap-Swift
feature/Geometry-Swift
feature/Cluster-Swift
feature/Cluster-QuadTree-Heatmap-Geometry-swift
Validations
codecov
- 82.3%