-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google maps warns about using click instead of gmp-click event. #611
Comments
If you would like to upvote the priority of this issue, please comment below or react with 👍 so we can see what is popular when we triage.@coder6652 Thank you for opening this issue. 🙏
This is an automated message, feel free to ignore. |
Which version of the markerclusterer are you seeing this in? |
I’m using [markerclusterer@2.1.0beta.2](mailto:markerclusterer@2.1.0beta.2).
This is the CDN:
<script src="https://unpkg.com/@googlemaps/markerclusterer@2.1.0-beta.2/dist/index.min.js"></script>
I hope this is the right version?
If you cannot reproduce it, please let me know.
It is only a warning and everything still works but you don’t want that showing up in the browser console.
Something you should know. I was trying to get the OnClusterClick handler to work and I got it to work but only when using this syntax.
markerCluster.onClusterClick = function (e, cluster) { … }
Then, I was trying to figure out how to change the background and glyph color of a specific cluster.
I had to use the cluster.marker.content property which is an HTMLElement that is an SVG and then I had to find the fill attribute and change the color by changing the three fill attributes that define the text color, background color, and glyph color. It worked but it took several hours to figure this out. I am not sure if there is an easier way to do this?
From: Alex Muramoto ***@***.***
Sent: Friday, May 12, 2023 1:00 PM
To: googlemaps/js-markerclusterer ***@***.***>
Cc: coder6652 ***@***.***>; Mention ***@***.***>
Subject: Re: [googlemaps/js-markerclusterer] Google maps warns about using click instead of gmp-click event. (Issue #611)
Which version of the markerclusterer are you seeing this in?
—
Reply to this email directly, view it on GitHub <#611 (comment)> , or unsubscribe <https://github.com/notifications/unsubscribe-auth/A6SJEEUFWWHJUM77TXGYBRDXFZUB5ANCNFSM6AAAAAAX6S7WXI> .
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
I am seeing this with 2.1.3 as well but the it looks like the pb is rather the JS maps API: Looking at the docs for
@jeantimex is a) use What are your thoughts here? |
I don't think there is anything to do here while Once/If it makes its way into the weekly channel we should feature detect the way to add click listeners. |
This is the error in the browser console from google maps.
I
I am not getting this error when not using the marker clusterer.
The text was updated successfully, but these errors were encountered: