fix: prevent gmp-click warnings when using AdvancedMarkerElement #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of February 21, 2024, `google.maps.Marker` is deprecated in favor of `google.maps.marker.AdvancedMarkerElement`. When handling click events:
- Standard `google.maps.Marker` uses the `"click"` event.
- `google.maps.marker.AdvancedMarkerElement` requires `"gmp-click"` instead.
This fixes the warning: `Please use addEventListener('gmp-click', ...) instead of addEventListener('click', ...).` which occurs when advanced markers are used.
usefulthink
reviewed
Feb 10, 2025
usefulthink
reviewed
Feb 10, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Feb 10, 2025
This fixes the warning: `Please use addEventListener('gmp-click', ...) instead of addEventListener('click', ...).` which occurs when advanced markers are used.
---------
Co-authored-by: Martin Schuhfuss <m.schuhfuss@gmail.com> e43e3e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of February 21, 2024,
google.maps.Markeris deprecated in favor ofgoogle.maps.marker.AdvancedMarkerElement. When handling click events:google.maps.Markeruses the"click"event.google.maps.marker.AdvancedMarkerElementrequires"gmp-click"instead.This fixes the warning:
Please use addEventListener('gmp-click', ...) instead of addEventListener('click', ...).which occurs when advanced markers are used.Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #611 🦕