Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(calendar): Fixed broken link and added support for indirect members or multiple groups to Team Calendar #390

Merged
merged 2 commits into from
Apr 17, 2023

Conversation

lwcorp
Copy link
Contributor

@lwcorp lwcorp commented Apr 17, 2023

Description

  1. Fixed a broken link in the README to the vacation calendar script. Without this fix, users may not find this script.
  2. Added a feature to the vacation to also support indirect members or multiple groups. Without it the calendar is limited since many groups also contain indirect members and there was no alternative to manually specify multiple groups.

Is it been tested?

  • Production testing done

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have performed a peer-reviewed with team member(s)
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@google-cla
Copy link

google-cla bot commented Apr 17, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@lwcorp lwcorp changed the title Patch 1 Team Vacation Calendar: Fixed broken link and added support for indirect members or multiple groups Apr 17, 2023
@lwcorp lwcorp changed the title Team Vacation Calendar: Fixed broken link and added support for indirect members or multiple groups feat (calendar): Fixed broken link and added support for indirect members or multiple groups to Team Calendar Apr 17, 2023
@lwcorp lwcorp changed the title feat (calendar): Fixed broken link and added support for indirect members or multiple groups to Team Calendar feat(calendar): Fixed broken link and added support for indirect members or multiple groups to Team Calendar Apr 17, 2023
@jpoehnelt jpoehnelt merged commit 25dad78 into googleworkspace:main Apr 17, 2023
@lwcorp
Copy link
Contributor Author

lwcorp commented Apr 17, 2023

Thanks for the approval! Do you think you can update Populate a team vacation calendar (or more specifically the production script) with these features?

@jpoehnelt
Copy link
Member

It should update within about 24 hours.

@lwcorp
Copy link
Contributor Author

lwcorp commented Apr 19, 2023

It should update within about 24 hours.

Any update on this? Almost 2 days passed:
image

@jpoehnelt
Copy link
Member

Where did you find a link to that?

@lwcorp
Copy link
Contributor Author

lwcorp commented Apr 19, 2023

@lwcorp lwcorp deleted the patch-1 branch May 2, 2023 17:25
@lwcorp lwcorp restored the patch-1 branch May 2, 2023 17:25
@lwcorp lwcorp deleted the patch-1 branch May 2, 2023 17:25
@lwcorp lwcorp restored the patch-1 branch May 2, 2023 17:25
@lwcorp lwcorp deleted the patch-1 branch May 2, 2023 17:25
@lwcorp
Copy link
Contributor Author

lwcorp commented May 2, 2023

Where did you find a link to that?

Did you have a chance to review that link?

brentchang pushed a commit to brentchang/apps-script-samples that referenced this pull request Dec 3, 2023
…ers or multiple groups to Team Calendar (googleworkspace#390)

* Added support for also adding indirect members or multiple groups

* Fixed broken link
@lwcorp
Copy link
Contributor Author

lwcorp commented Jan 12, 2024

Thanks for finally integrating it after all these months! It's good to start 2024 with my added features in your script.
You had to update the official script because of this bug, but maybe you should regularly sync it with GitHub instead of relying on custom copy/paste that you do only after serious bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants