-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automate dependency management of spx2 #1204
Conversation
Skipping CI for Draft Pull Request. |
13099e7
to
14b6fdb
Compare
.github/workflows/validate.yml
Outdated
- name: Build WASM | ||
working-directory: spx-gui | ||
run: npm run build-wasm | ||
|
||
- name: Setup Go 1.23.4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- name: Setup Go 1.23.4 | |
- name: Set up Go |
这样应该就好?写两次版本号怪麻烦的😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嗯是的现在版本号没必要了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
Install spx2 as an external dependency instead of committing it, close Automate dependency management of spx2 #1202.
Standardized global toolchain versions and build scripts:
Global toolchain versions: Go v1.23.4, Node v20.11.1
For internal projects, which requires different version of go toolchain, e.g.,
tools/fmt
&tools/ispx
, useGOTOOLCHAIN=gox.y.z
to specify it locallyConsistent build scripts for three environments (GitHub Action, Vercel, Docker)
Remove outdated content from
spx-gui/README.md
.Related: