Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate dependency management of spx2 #1204

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Jan 7, 2025

  • Install spx2 as an external dependency instead of committing it, close Automate dependency management of spx2 #1202.

  • Standardized global toolchain versions and build scripts:

    • Global toolchain versions: Go v1.23.4, Node v20.11.1

      For internal projects, which requires different version of go toolchain, e.g., tools/fmt & tools/ispx, use GOTOOLCHAIN=gox.y.z to specify it locally

    • Consistent build scripts for three environments (GitHub Action, Vercel, Docker)

      # Install deps
      npm install
      ./install-spx.sh
      
      # Run or build code
      ./build-wasm.sh
      npm run dev # or `npm run build`
  • Remove outdated content from spx-gui/README.md.

Related:

Copy link

qiniu-prow bot commented Jan 7, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

- name: Build WASM
working-directory: spx-gui
run: npm run build-wasm

- name: Setup Go 1.23.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- name: Setup Go 1.23.4
- name: Set up Go

这样应该就好?写两次版本号怪麻烦的😂

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯是的现在版本号没必要了

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dockerfile Show resolved Hide resolved
spx-gui/install-spx.sh Show resolved Hide resolved
@qiniu-ci
Copy link

qiniu-ci commented Jan 8, 2025

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@aofei aofei merged commit d8156a5 into goplus:dev Jan 8, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate dependency management of spx2
3 participants