-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPX 2.0 Integration #1083
SPX 2.0 Integration #1083
Conversation
Skipping CI for Draft Pull Request. |
f16bd57
to
bd54b95
Compare
[Git-flow] Hi @nighca, There are some suggestions for your information: Rebase suggestions
Which seems insignificant, recommend to use For other If you have any questions about this comment, feel free to raise an issue here: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 12 out of 22 changed files in this pull request and generated 1 suggestion.
Files not reviewed (10)
- spx-gui/public/runner/.gitignore: Language not supported
- spx-gui/public/runner/20241119_1605/runner.html: Language not supported
- spx-gui/src/components/project/runner/v1/ProjectRunnerV1.vue: Evaluated as low risk
- spx-gui/src/components/editor/preview/EditorPreview.vue: Evaluated as low risk
- spx-gui/src/components/editor/preview/RunnerContainer.vue: Evaluated as low risk
- spx-gui/src/components/project/runner/ProjectRunner.vue: Evaluated as low risk
- spx-gui/src/components/project/runner/v2/ProjectRunnerV2.vue: Evaluated as low risk
- spx-gui/src/pages/community/project.vue: Evaluated as low risk
- spx-gui/src/widgets/spx-runner/SpxRunner.ce.vue: Evaluated as low risk
- spx-gui/src/models/common/hash.ts: Evaluated as low risk
This PR has been deployed to the preview environment. You can explore it using the preview URL. Warning Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 12 out of 22 changed files in this pull request and generated no suggestions.
Files not reviewed (10)
- spx-gui/public/runner/.gitignore: Language not supported
- spx-gui/public/runner/20241119_1605/runner.html: Language not supported
- spx-gui/src/components/project/runner/v1/ProjectRunnerV1.vue: Evaluated as low risk
- spx-gui/src/components/editor/preview/EditorPreview.vue: Evaluated as low risk
- spx-gui/src/components/editor/preview/RunnerContainer.vue: Evaluated as low risk
- spx-gui/src/components/project/runner/ProjectRunner.vue: Evaluated as low risk
- spx-gui/src/components/project/runner/v2/ProjectRunnerV2.vue: Evaluated as low risk
- spx-gui/src/pages/community/project.vue: Evaluated as low risk
- spx-gui/src/widgets/spx-runner/SpxRunner.ce.vue: Evaluated as low risk
- spx-gui/src/utils/utils.ts: Evaluated as low risk
Close #1066.
Changes
/public/runner/<version>/*
Cross-Origin-*
HTTP headers for (HTML) document responsesProjectRunner
toProjectRunnerV1
; addProjectRunnerV2
andProjectRunner
for switching supportNote: There are known issues with spx v2 that do not affect the default behavior of spx v1.
How to enable spx v2
Add
spx=v2
in the URL query when opening pages, e.g.,https://<host>/project/nighca/test?spx=v2
. This setting will be retained for subsequent navigation. Usespx=v1
to clear it.