Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPX 2.0 Integration #1083

Merged
merged 8 commits into from
Nov 20, 2024
Merged

SPX 2.0 Integration #1083

merged 8 commits into from
Nov 20, 2024

Conversation

nighca
Copy link
Collaborator

@nighca nighca commented Nov 12, 2024

Close #1066.

Changes

  • Add spx v2 and gdspx assets to /public/runner/<version>/*
  • Add Cross-Origin-* HTTP headers for (HTML) document responses
  • Rename ProjectRunner to ProjectRunnerV1; add ProjectRunnerV2 and ProjectRunner for switching support
  • Render project-runner upon editor initialization for flexible preloading

Note: There are known issues with spx v2 that do not affect the default behavior of spx v1.

How to enable spx v2

Add spx=v2 in the URL query when opening pages, e.g., https://<host>/project/nighca/test?spx=v2. This setting will be retained for subsequent navigation. Use spx=v1 to clear it.

Copy link

qiniu-prow bot commented Nov 12, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

qiniu-x bot commented Nov 13, 2024

[Git-flow] Hi @nighca, There are some suggestions for your information:


Rebase suggestions

  • Following commits have duplicated messages

    details

    details

Which seems insignificant, recommend to use git rebase command to reorganize your PR.

For other git-flow instructions, recommend refer to these examples.

If you have any questions about this comment, feel free to raise an issue here:

@nighca nighca changed the title [WIP] SPX 2.0 Integration SPX 2.0 Integration Nov 13, 2024
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 22 changed files in this pull request and generated 1 suggestion.

Files not reviewed (10)
  • spx-gui/public/runner/.gitignore: Language not supported
  • spx-gui/public/runner/20241119_1605/runner.html: Language not supported
  • spx-gui/src/components/project/runner/v1/ProjectRunnerV1.vue: Evaluated as low risk
  • spx-gui/src/components/editor/preview/EditorPreview.vue: Evaluated as low risk
  • spx-gui/src/components/editor/preview/RunnerContainer.vue: Evaluated as low risk
  • spx-gui/src/components/project/runner/ProjectRunner.vue: Evaluated as low risk
  • spx-gui/src/components/project/runner/v2/ProjectRunnerV2.vue: Evaluated as low risk
  • spx-gui/src/pages/community/project.vue: Evaluated as low risk
  • spx-gui/src/widgets/spx-runner/SpxRunner.ce.vue: Evaluated as low risk
  • spx-gui/src/models/common/hash.ts: Evaluated as low risk

spx-gui/src/utils/utils.ts Outdated Show resolved Hide resolved
@qiniu-ci
Copy link

This PR has been deployed to the preview environment. You can explore it using the preview URL.

Warning

Please note that deployments in the preview environment are temporary and will be automatically cleaned up after a certain period. Make sure to explore it before it is removed. For any questions, contact the Go+ Builder team.

@aofei aofei requested a review from Copilot November 20, 2024 02:34

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 12 out of 22 changed files in this pull request and generated no suggestions.

Files not reviewed (10)
  • spx-gui/public/runner/.gitignore: Language not supported
  • spx-gui/public/runner/20241119_1605/runner.html: Language not supported
  • spx-gui/src/components/project/runner/v1/ProjectRunnerV1.vue: Evaluated as low risk
  • spx-gui/src/components/editor/preview/EditorPreview.vue: Evaluated as low risk
  • spx-gui/src/components/editor/preview/RunnerContainer.vue: Evaluated as low risk
  • spx-gui/src/components/project/runner/ProjectRunner.vue: Evaluated as low risk
  • spx-gui/src/components/project/runner/v2/ProjectRunnerV2.vue: Evaluated as low risk
  • spx-gui/src/pages/community/project.vue: Evaluated as low risk
  • spx-gui/src/widgets/spx-runner/SpxRunner.ce.vue: Evaluated as low risk
  • spx-gui/src/utils/utils.ts: Evaluated as low risk
@aofei aofei merged commit 4dd56e1 into goplus:dev Nov 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SPX 2.0 Integration
3 participants