S23 user privacy setting #937
Conversation
…/gordon-360-api into s23-fac-privacy-option
Caused by await not being called on an async service Update logic to be less clunky
amos-cha
requested review from
bennettforkner,
russtuck,
EjPlatzer and
amos-cha
and removed request for
bennettforkner
|
The [UserPrivacy_Settings], [UserPrivacy_Fields]. and [UserPrivacy_Visibility_Groups] tables, and the users' privacy data based on their previous privacy setting have been added to the production Database by @amos-cha. Thank you! |
|
There are build errors after the merge from develop. Please fix them. |
| </member> | ||
| </members> | ||
| </doc> | ||
| <?xml version="1.0"?> |
There was a problem hiding this comment.
I'm puzzled about why github is showing that every single line of this file has changed Many seem the same, but some are different. I can't find a commit that changes more than a small piece, and blame shows most lines haven't changed for weeks or months. Do you know why it thinks every single line of this file changed?
There was a problem hiding this comment.
Yeah this also confuses me. I don't know why GitHub thinks every line of code in this file has been changed.. Some new code was added, such as mail location and user privacy, but most of the code has not been changed.
This reverts commit 1210ca0.
This reverts commit 8d8ab77.
…/gordon-360-api into s23-fac-privacy-option
|
This PR is closed due to the difficulty of solving the merging conflicts here. This is the new PR: #1042. |
Allow users to choose which phone numbers they would like to show in their profiles and some other privacy options.
Fixes gordon-cs/gordon-360-ui#1308
Fixes gordon-cs/gordon-360-ui#1897
UI: gordon-cs/gordon-360-ui#1931