Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

S23 user privacy setting #937

Closed
wants to merge 51 commits into from
Closed

S23 user privacy setting #937

wants to merge 51 commits into from

Commits on Jun 27, 2023

  1. Update EF Core models

    @ArabellaJi
    ArabellaJi committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    b407dad View commit details
    Browse the repository at this point in the history

  2. continue EF Core update

    @ArabellaJi
    ArabellaJi committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    daaa94f View commit details
    Browse the repository at this point in the history

  3. add mobilePhone, isMobilePhonePrivate, and isHomePhonePrivate

    @ArabellaJi
    ArabellaJi committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    8d0f4ec View commit details
    Browse the repository at this point in the history

  4. add UpdateHomePrivacyAsync - not working yet

    @ArabellaJi
    ArabellaJi committed Jun 27, 2023
    Configuration menu
    Copy the full SHA
    3adcc9a View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2023

  1. fix the error

    @ArabellaJi
    ArabellaJi committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    4eb6757 View commit details
    Browse the repository at this point in the history

  2. remove isMobilePhonePrivate and isHomePhonePrivate for fac/staff

    @ArabellaJi
    ArabellaJi committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    d870395 View commit details
    Browse the repository at this point in the history

  3. remove UpdateHomePrivacyAsync from ProfileController and ProfileServi… 

    …ce temporarily
    @ArabellaJi
    ArabellaJi committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    ab48999 View commit details
    Browse the repository at this point in the history

  4. modifying UpdateFacStaffPrivacyAsync - not working

    @ArabellaJi
    ArabellaJi committed Jun 28, 2023
    Configuration menu
    Copy the full SHA
    ca323c1 View commit details
    Browse the repository at this point in the history

Commits on Jun 29, 2023

  1. finishing update route

    @ArabellaJi
    ArabellaJi committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    9b6189d View commit details
    Browse the repository at this point in the history

Commits on Jun 30, 2023

  1. decided using one row for each User and Field

    @ArabellaJi
    ArabellaJi committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    3a768b3 View commit details
    Browse the repository at this point in the history

  2. Update table connections

    @amos-cha
    amos-cha committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    e3c398e View commit details
    Browse the repository at this point in the history

  3. Fix syntax errors

    @amos-cha
    amos-cha committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    7f5f0c2 View commit details
    Browse the repository at this point in the history

  4. Merge branch 's23-fac-privacy-option' of https://github.com/gordon-cs… 

    …/gordon-360-api into s23-fac-privacy-option
    @amos-cha
    amos-cha committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    4fbbafb View commit details
    Browse the repository at this point in the history

  5. finishing get profile functions

    @ArabellaJi
    ArabellaJi committed Jun 30, 2023
    Configuration menu
    Copy the full SHA
    ee37a34 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2023

  1. using a better way to wipe out the private imformation

    @ArabellaJi
    ArabellaJi committed Jul 3, 2023
    Configuration menu
    Copy the full SHA
    3ab1e77 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2023

  1. Update variable naming

    @amos-cha
    amos-cha committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    ee5e0cb View commit details
    Browse the repository at this point in the history

  2. Update to use route instead of direct cast

    @amos-cha
    amos-cha committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    3dcbf87 View commit details
    Browse the repository at this point in the history

  3. Deprecate use of privacy bit for FacStaff

    @amos-cha
    amos-cha committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    48c14ab View commit details
    Browse the repository at this point in the history

  4. Fix async race condition 

    Caused by await not being called on an async service
Update logic to be less clunky
    @amos-cha
    amos-cha committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    2cd45e3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into s23-fac-privacy-option

    @amos-cha
    amos-cha authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    0c06b6c View commit details
    Browse the repository at this point in the history

  6. Manage minor cleanup

    @amos-cha
    amos-cha authored Jul 5, 2023
    Configuration menu
    Copy the full SHA
    389f69d View commit details
    Browse the repository at this point in the history

  7. Add SyB to put route

    @amos-cha
    amos-cha committed Jul 5, 2023
    Configuration menu
    Copy the full SHA
    36d0bad View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. add primary key

    @ArabellaJi
    ArabellaJi committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    1af67aa View commit details
    Browse the repository at this point in the history

  2. update comments for UserPrivacyViewModel.cs

    @ArabellaJi
    ArabellaJi committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    f20b553 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2023

  1. adding get privacy setting

    @ArabellaJi
    ArabellaJi committed Jul 10, 2023
    Configuration menu
    Copy the full SHA
    b029f18 View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2023

  1. working on get privacy setting

    @ArabellaJi
    ArabellaJi committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    9339e46 View commit details
    Browse the repository at this point in the history

  2. distinguish Country and HomeCountry

    @ArabellaJi
    ArabellaJi committed Jul 11, 2023
    Configuration menu
    Copy the full SHA
    8e5b4c8 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2023

  1. add comments and test for ToPublicProfileViewModel

    @ArabellaJi
    ArabellaJi committed Jul 12, 2023
    Configuration menu
    Copy the full SHA
    6693a05 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2023

  1. change async functions to not async functions

    @ArabellaJi
    ArabellaJi committed Jul 13, 2023
    Configuration menu
    Copy the full SHA
    517d5a6 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2023

  1. completed privacy setting for Home field

    @ArabellaJi
    ArabellaJi committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    0ad3c9c View commit details
    Browse the repository at this point in the history

  2. cleaning up

    @ArabellaJi
    ArabellaJi committed Jul 14, 2023
    Configuration menu
    Copy the full SHA
    e666a49 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2023

  1. simplify querying

    @ArabellaJi
    ArabellaJi committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    a48035b View commit details
    Browse the repository at this point in the history

  2. continue to simplify querying (GetPrivacySettingAsync)

    @ArabellaJi
    ArabellaJi committed Jul 17, 2023
    Configuration menu
    Copy the full SHA
    5f5c062 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. change the fields from strings to lists of strings

    @ArabellaJi
    ArabellaJi committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    4ad5dce View commit details
    Browse the repository at this point in the history

  2. using implicitly cast

    @ArabellaJi
    ArabellaJi committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    d44a44e View commit details
    Browse the repository at this point in the history

  3. remove unused comments

    @ArabellaJi
    ArabellaJi committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    ca65e18 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. continue to clean up code

    @ArabellaJi
    ArabellaJi committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    ede4917 View commit details
    Browse the repository at this point in the history

  2. resolve merge conflicts

    @ArabellaJi
    ArabellaJi committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    bb21116 View commit details
    Browse the repository at this point in the history

  3. changing comments

    @ArabellaJi
    ArabellaJi committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    5f9c2ca View commit details
    Browse the repository at this point in the history

  4. add HomePhone for student in public profile

    @ArabellaJi
    ArabellaJi committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    416c1e1 View commit details
    Browse the repository at this point in the history

  5. remove unnecessary lines

    @ArabellaJi
    ArabellaJi committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    32128b8 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'develop' into s23-fac-privacy-option

    @ArabellaJi
    ArabellaJi authored Jul 21, 2023
    Configuration menu
    Copy the full SHA
    7fd260c View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2023

  1. Merge branch 'develop' into s23-fac-privacy-option

    @ArabellaJi
    ArabellaJi authored Jul 22, 2023
    Configuration menu
    Copy the full SHA
    6e8e19c View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2023

  1. Merge branch 'develop' into s23-fac-privacy-option

    @ArabellaJi
    ArabellaJi authored Jul 24, 2023
    Configuration menu
    Copy the full SHA
    2a99d70 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. fix minor spelling issue

    @ArabellaJi
    ArabellaJi authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    1342930 View commit details
    Browse the repository at this point in the history

  2. change the order of parameters and add a comment

    @ArabellaJi
    ArabellaJi authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    414263c View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2023

  1. initial add roommate completed

    @ArabellaJi
    ArabellaJi committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    1210ca0 View commit details
    Browse the repository at this point in the history

  2. Revert "initial add roommate completed" 

    This reverts commit 1210ca0.
    @ArabellaJi
    ArabellaJi committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    8d8ab77 View commit details
    Browse the repository at this point in the history

  3. Revert "Revert "initial add roommate completed"" 

    This reverts commit 8d8ab77.
    @ArabellaJi
    ArabellaJi committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    5979e60 View commit details
    Browse the repository at this point in the history

Commits on May 21, 2024

  1. Merge branch 's23-fac-privacy-option' of https://github.com/gordon-cs… 

    …/gordon-360-api into s23-fac-privacy-option
    @ArabellaJi
    ArabellaJi committed May 21, 2024
    Configuration menu
    Copy the full SHA
    0de79fe View commit details
    Browse the repository at this point in the history

  2. fixed a few issue

    @ArabellaJi
    ArabellaJi committed May 21, 2024
    Configuration menu
    Copy the full SHA
    6d0f528 View commit details
    Browse the repository at this point in the history