element-picker: Declare we support both light and dark color-schemes. #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes uBlockOrigin/uBlock-issues#2240 and should get the desired behavior regardless of browser. Delay showing the iframe until load to prevent flashing a white background on the initial about:blank.
8 tasks
|
Thanks, that solution is beyond what I could have done with my limited understanding of the issue. |
Repository owner
deleted a comment from
ps9779
Oct 11, 2022
gdh1995
added a commit
to gdh1995/vimium-c
that referenced
this pull request
Nov 1, 2022
See philc/vimium#4159 . `color-scheme: light dark;` works perfectly on Firefox 105/106 and Chrome 88/99/106 during my testes. 1. The changes which breaks `color-scheme: light`, as reported in philc/vimium#4148, is caused by a fix of https://bugzilla.mozilla.org/show_bug.cgi?id=1782596 . 2. And then I searched and found [1789338 - Element picker is light themed when uBlock origin theme is set to auto in Nightly](https://bugzilla.mozilla.org/show_bug.cgi?id=1789338) 3. So I installed uBlock Origin and tested its picker iframe, and noticed `color-scheme: light dark` (gorhill/uBlock#3872)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes uBlockOrigin/uBlock-issues#2240 and should get the desired behavior regardless of browser.
Delay showing the iframe until load to prevent flashing a white background on the initial about:blank.