Fix regression of background colors (dark mode) of Vimium iframes #4159
Conversation
I just found uBlock Origin applies `color-scheme: light dark` onto its iframes.
gdh1995
force-pushed
the
fix-color-scheme-on-ff
branch
from
cd014e0 to
ba4547e
Compare
gdh1995
changed the title
See philc/vimium#4159 . `color-scheme: light dark;` works perfectly on Firefox 105/106 and Chrome 88/99/106 during my testes. 1. The changes which breaks `color-scheme: light`, as reported in philc/vimium#4148, is caused by a fix of https://bugzilla.mozilla.org/show_bug.cgi?id=1782596 . 2. And then I searched and found [1789338 - Element picker is light themed when uBlock origin theme is set to auto in Nightly](https://bugzilla.mozilla.org/show_bug.cgi?id=1789338) 3. So I installed uBlock Origin and tested its picker iframe, and noticed `color-scheme: light dark` (gorhill/uBlock#3872)
The problem persists with |
This comment was marked as resolved.
This comment was marked as resolved.
|
@nikinbaidar Sorry but had you added |
No. Do I need to add this on every html file in there? |
|
You may just apply all modification in this PR - it's enough. |
|
Yeah! Seems like it did it. Had to modify things as per your commit. Please merge this ASAP so that this can sustain over reboots. |
philc
changed the title
|
This fixes the cases I was noticing. Thanks for the detective work @gdh1995 . |
Updated:
color-scheme: light dark;works perfectly on Firefox 105/106 and Chrome 88/99/106 during my testes.color-scheme: light, as reported in 'prefers-color-scheme: dark' doesn't work in vomnibar #4148, is caused by a fix of https://bugzilla.mozilla.org/show_bug.cgi?id=1782596 .color-scheme: light dark(element-picker: Declare we support both light and dark color-schemes. gorhill/uBlock#3872)Then this fixes #4156 and replaces commit fbeee3d.