Using capture groups in path regexes has unexpected behaviour

[endophage]

I think this is probably just a docs improvement. Unless it's buried somewhere, the docs don't specify that regexes shouldn't be wrapped in a capture group. Doing so causes unexpected behavior when used in any location but the last regex.

Examples:

• Path: "/{name:.*}.{ext:([a-zA-Z0-9]+)}"
  • input "/foo.bar"
  • vars equals map[name:foo ext:bar]
• Path: "/{name:(.*)}.{ext:[a-zA-Z0-9]+}"
  • input "/foo.bar"
  • vars equals map[name:foo ext:foo]

It would be great if the docs clearly stated that the regexes shouldn't have an enclosing capture group. At the moment it can only be inferred from the examples, which becomes especially confusing when it works some of the time (i.e. when the only capture group is the final regex).

[elithrar]

Thanks for reporting this! I'll fix the docs to make this clearer.

[elithrar]

This may have changed since #144 and #155 - can you confirm?

[endophage]

Appears to still be broken. I ran my tests against the older version (e444e69) I had in my go vendoring, saw the expected failure, updated to mux's head of master, ran the same tests and got the same failure.

[elithrar]

Did you want to submit a PR updating the docs? I won't have time for a while.

[endophage]

I'm a little overbooked right now too. No promised but if I get time I'll submit an update.

[olt]

I was hit by this issue, but it's possible to workaround with non-capturing groups. #196 contains an update to the documentation.

[elithrar]

Refer to #200