Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cancelling an appeal doesn't change the pending approvers status #18

Closed
bsushmith opened this issue Apr 10, 2023 · 3 comments · Fixed by #25
Closed

cancelling an appeal doesn't change the pending approvers status #18

bsushmith opened this issue Apr 10, 2023 · 3 comments · Fixed by #25

Comments

@bsushmith
Copy link
Collaborator

Description
When an appeal gets created, based on the policy steps, approval records are also created in approvals and approvers tables.

When the appeal gets cancelled by the user, only the status of the appeal is changed and the status of the approval is still kept as pending.

To Reproduce

  • create an appeal with policy which has manual approvals involved.
  • cancel the appeal
  • check the status of the manual approval in approvals table

Expected behavior
Approvals should also marked as canceled in addition to the appeal. The below are the current status types in approvals. we need to have a canceled type to factor in user cancellations.
image
@rahmatrhd
Copy link
Member

Although it's not an incorrect state for approvals that the appeal is canceled, why are approvals with status canceled explicitly needed? IMO we can already infer from the appeal status that if it is a canceled, any pending/blocked approvals shouldn't be actionable a.k.a the approvals are locked.

@bsushmith
Copy link
Collaborator Author

The approvals API returns approvals based on filters. One would not be able to exclude these un-actionable approvals from approvals API with current set of filters.

@bsushmith
Copy link
Collaborator Author

bsushmith commented Apr 27, 2023 •
edited
Loading

Finalized Approach -

@rahmatrhd

@bsushmith bsushmith linked a pull request Apr 27, 2023 that will close this issue
feat(approval): add appeal_statuses filter for list approvals API #25
Merged
1 task
lifosmin pushed a commit to lifosmin/guardian that referenced this issue Aug 31, 2023
@anjali9791 @anjaliagg9791
feat(compass): add support for group asset api (goto#18)
b2410c7 
* feat(compass): add support for group asset api
Related to : goto/compass#19

* feat(group assets): group by and include-fields changed to string from array.

* feat(group assets): add a struct to contain info on grouped fields and grouped field value

* changes as per review comments

* rename GroupFieldInfo to GroupFields

* change groupby and include fields  from string to []string

* update the description of fields in group assets api

---------

Co-authored-by: anjali.agarwal <anjali.aggarwal@gojek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(approval): add appeal_statuses filter for list approvals API goto/guardian
2 participants
@rahmatrhd @bsushmith