Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(approval): add appeal_statuses filter for list approvals API #25

Merged
merged 5 commits into from
May 2, 2023
Merged

feat(approval): add appeal_statuses filter for list approvals API #25

merged 5 commits into from
May 2, 2023

Conversation

bsushmith
Copy link
Collaborator

@bsushmith bsushmith commented Apr 27, 2023 •
edited
Loading

Proton PR - goto/proton#16

Todo:

  • test cases

@coveralls
Copy link

coveralls commented Apr 27, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4858136331

  • 19 of 19 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 75.286%
Totals Coverage Status
Change from base Build 4857688986: 0.01%
Covered Lines: 7975
Relevant Lines: 10593
💛 - Coveralls

@bsushmith bsushmith mentioned this pull request Apr 27, 2023
Closed
@bsushmith bsushmith linked an issue Apr 27, 2023 that may be closed by this pull request
cancelling an appeal doesn't change the pending approvers status #18
Closed
@bsushmith bsushmith requested a review from rahmatrhd May 2, 2023 04:45
@bsushmith bsushmith force-pushed the 18/approvals/canceled-appeals branch from 3a4d3e3 to 7f36d61 Compare May 2, 2023 06:06
@bsushmith bsushmith merged commit 3c37a41 into main May 2, 2023
@bsushmith bsushmith deleted the 18/approvals/canceled-appeals branch May 2, 2023 10:44
lifosmin pushed a commit to lifosmin/guardian that referenced this pull request Aug 31, 2023
@krtkvrm
fix: depreciate policy action role APIs which can be accessible by IDs (
a1795af 
goto#25)

feat: remove unnecessary API for roles, policies and actions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahmatrhd rahmatrhd rahmatrhd approved these changes

@utsav14nov utsav14nov Awaiting requested review from utsav14nov

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cancelling an appeal doesn't change the pending approvers status
3 participants
@bsushmith @coveralls @rahmatrhd