Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Dashboard Exposures Issue #246

Merged
merged 2 commits into from
Mar 28, 2024

Conversation

yasminadimy
Copy link
Contributor

@yasminadimy yasminadimy commented Mar 27, 2024

Hello! 👋
I hope this message finds you well.

I recently encountered an issue in my environment where I wasn't able to retrieve the dashboard exposures, whereas the functionality worked seamlessly for cards. Upon investigating, I suspect that there might have been a change in the reference handling, which could be causing this discrepancy.

Here is a PR to handle the change and ensure consistent retrieval of both dashboard and card exposures!

Your feedback and review of the proposed changes would be greatly appreciated. Please feel free to reach out if you have any questions or suggestions regarding this PR ! ☀️

@gouline gouline changed the title 🐛 Fix Dashboard Exposures Issue Fix Dashboard Exposures Issue Mar 27, 2024
dbtmetabase/_exposures.py Outdated Show resolved Hide resolved
Co-authored-by: Mike Gouline <1960272+gouline@users.noreply.github.com>
@gouline gouline merged commit 7a98a24 into gouline:master Mar 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants