Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Dashboard Exposures Issue #246

Merged
merged 2 commits into from
Mar 28, 2024
Merged

Fix Dashboard Exposures Issue #246

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0e96100
:bug: Fix json ref name
yasminadimy Mar 27, 2024
26ae9a9
Update dbtmetabase/_exposures.py
yasminadimy Mar 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dbtmetabase/_exposures.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@ def extract_exposures(
continue

entity = dashboard_entity
cards = entity.get("ordered_cards", [])
cards = entity.get("dashcards", [])
yasminadimy marked this conversation as resolved.
Show resolved Hide resolved
if not cards:
continue

Expand Down
2 changes: 1 addition & 1 deletion tests/fixtures/api/dashboard/1.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
"description": null,
"archived": false,
"collection_position": 1,
"ordered_cards": [
"dashcards": [
{
"sizeX": 18,
"series": [],
Expand Down
Loading