Skip tables that are technical not just hidden #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tables are hidden with any non-nil value - we hide our tables with `technical` so would be useful to update this.
gouline
requested changes
Jul 12, 2024
| @@ -100,7 +100,7 @@ def export_models( | |||
|
|
|||
| field = table.get("fields", {}).get(column_name) | |||
| if not field: | |||
| if table.get("visibility_type") == "hidden": | |||
| if table.get("visibility_type") is not None: | |||
There was a problem hiding this comment.
Not the only instance of "hidden" comparison in this file that you need to fix
There was a problem hiding this comment.
ah sorry - been a busy week - I can see you've merged this anyway so thanks!
Merged
gouline
added a commit
that referenced
this pull request
Jul 19, 2024
* Skip tables that are technical not just hidden (#267) Tables are hidden with any non-nil value - we hide our tables with `technical` so would be useful to update this. * Allow other table hidden values --------- Co-authored-by: Chris Parsons <cp@lollipopai.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tables are hidden with any non-nil value - we hide our tables with
technicalso would be useful to update this.