Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip tables that are technical not just hidden #267

Merged
merged 1 commit into from
Jul 19, 2024
Merged

Skip tables that are technical not just hidden #267

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dbtmetabase/_models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ def export_models(

field = table.get("fields", {}).get(column_name)
if not field:
if table.get("visibility_type") == "hidden":
if table.get("visibility_type") is not None:
Copy link
Owner

@gouline gouline Jul 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not the only instance of "hidden" comparison in this file that you need to fix

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry - been a busy week - I can see you've merged this anyway so thanks!

table_label = "hidden table"
table["stale"] = True
else:
Expand Down
Loading