Added an option to automatically hide the highlightLine #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documented the `didEndTouchingChart` delegate method and the `shouldAutoHideHighlightLine` property.
gpbl
reviewed
Apr 13, 2017
Owner
gpbl
left a comment
gpbl
left a comment
There was a problem hiding this comment.
Thanks for the PR! I believe a method like hideHighlightLine would work better than an option. What do you think?
Owner
|
Replaced by #79 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added an option to automatically hide the highlightLine when the touches on the chart have ended.
I needed this option for my particular use-case (I am showing a default message when no part of the graph is selected using the highlightLine).
I'm not 100% sure if this is the way to implement such a feature, but I thought I would give it a try (and it works as expected)
Furthermore I have updated the documentation in the readme with this property and #62