Optionally hide highlight line on didEndTouchingChart #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…didFinishTouchingChart is called, but there are some applications that might require to hide it after didEndTouchingChart.
A new property called removesHighlighLineOnTouchesEnded will takes care of hiding the highlight line if true, by default is false which is the default behavior.
Owner
|
Thanks for your work. Sorry for the super-late merge. Time to work on this library again :) |
gpbl
added a commit
that referenced
this pull request
Jan 6, 2018
#79 used removesHighlighLineOnTouchesEnded, better name is hideHighlightLineOnTouchEnd
Owner
|
(I renamed the property to |
This was referenced Jan 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a normal behavior the highlight line stays visible unless the
didFinishTouchingChartis called, but there are some applications that might need to hide it afterdidEndTouchingChart.A new boolean property called
removesHighlighLineOnTouchesEndedwill take care of removing the highlight line if true. By default this property is false which does not change the Chart's normal behavior of keeping the line visible whendidEndTouchingChartis called.