Skip to content

Conversation

@aydenp
Copy link

@aydenp aydenp commented Dec 6, 2017

Currently, when a user touches the chart and you have the highlight line enabled it will appear where they touched, but there is no way to remove this line programatically when they are done or you need this line gone.

This pull adds finishTouchingChart(), which will remove the line for you and call the delegate method didFinishTouchingChart(). It also modifies the touch handling code to use this method internally.

@gpbl
Copy link
Owner

gpbl commented Jan 6, 2018

Hey, thanks for your PR! The feature to hide the line when touch ends has been added via #79, thus your changes are not longer necessary.

@gpbl gpbl closed this Jan 6, 2018
@aydenp
Copy link
Author

aydenp commented May 5, 2018

Under some circumstances, you might need to do this programatically, still. In my app, I use it so that I can have the view stay highlighted when the user isn't touching, but removes this line when the user starts scrolling down the page, in another view.

Perhaps this pull request could be merged, with it's function renamed to removeHighlightLine() as a public function. This, combined with the functionality in #79, would eliminate almost any case where this would be impossible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants